23895[BUGFIX] Enable BE search for multiple mountpoints
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Jigal van Hemert +1
-
Verified V +2
- Georg Ringer +2
- Jigal van Hemert +1
Issues 1
Files 4
Review log 19
-
Mr. Jenkins commented on patch set 1 09/19/13, 06:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10831/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10831/ : SUCCESS -
Markus Klein updated the commit message in patch set 1 09/19/13, 06:14
-
Mr. Jenkins commented on patch set 2 09/19/13, 06:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10834/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10834/ : SUCCESS -
Georg Ringer uploaded patch set 3 09/19/13, 08:38
-
Mr. Jenkins commented on patch set 3 09/19/13, 08:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10840/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10840/ : SUCCESS -
Markus Klein commented on patch set 2 09/19/13, 09:35
RecordList.php:190No space after cast.RecordList.php:320... or _the_ root page is...AbstractDatabaseRecordList.php:936since 6.2 -
Markus Klein commented on patch set 3 09/19/13, 09:36
My comments from patch set 2 are still valid. -
Jigal van Hemert commented on patch set 3 V -1 CR -1 09/20/13, 08:41
Collection of page IDs is incorrect.The commit message describes the problem, not really the change itself. The name of the function is more or less irrelevant, but the new behaviour should be mentioned here.RecordList.php:190space, or intval()AbstractDatabaseRecordList.php:936Deprecated since 6.2, will be removed 2 versions later.AbstractDatabaseRecordList.php:971The + (union) operator on arrays will only add items to the array if their *key* doesn't exist yet in the left hand array. array_merge() should be used here.AbstractDatabaseRecordList.php:978Also array_merge() -
Jigal van Hemert uploaded patch set 4 09/20/13, 13:05
-
Jigal van Hemert voted on patch set 4 V +1 CR +1 09/20/13, 13:07
-
Mr. Jenkins commented on patch set 4 09/20/13, 13:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10853/ : SUCCESS -
Markus Klein commented on patch set 4 09/20/13, 15:03
AbstractDatabaseRecordList.php:971Why is here no if($depth)?AbstractDatabaseRecordList.php:979I suggest to remove code duplication by moving the foreach below the if and simply setting the $allowedMounts to array($id) here. -
Jigal van Hemert commented on patch set 4 09/20/13, 18:08
AbstractDatabaseRecordList.php:971ReplyActually, $depth is currently always > 0. Otherwise this function isn't called anyway :-)AbstractDatabaseRecordList.php:979ReplyNot really much code duplicated actually, but feel free to push a new set... -
Markus Klein uploaded patch set 5 09/20/13, 18:51
-
Mr. Jenkins commented on patch set 5 09/20/13, 19:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10858/ : SUCCESS -
Jigal van Hemert commented on patch set 5 V +1 CR +1 09/22/13, 12:29
Minor rearrangement of code. -
Georg Ringer voted on patch set 5 V +1 CR +1 10/18/13, 04:06
-
Georg Ringer voted on patch set 5 V +2 CR +2 10/18/13, 04:06
-
Georg Ringer merged patch set 6 10/18/13, 04:07