Review main Merged

23895[BUGFIX] Enable BE search for multiple mountpoints

Georg Ringer CR +2 V +2 Normal +41 −11 updated 10/18/13, 04:07

Commit message

Backend search now allows search from all mounts of an editor.
If the root page is selected it will search in all mounts of the
backend user.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jigal van Hemert +1
  • Verified V +2
    • Georg Ringer +2
    • Jigal van Hemert +1

Issues 1

Files 4

Review log 19

  1. Mr. Jenkins commented on patch set 1 09/19/13, 06:01

  2. Markus Klein updated the commit message in patch set 1 09/19/13, 06:14

  3. Mr. Jenkins commented on patch set 2 09/19/13, 06:33

  4. Georg Ringer uploaded patch set 3 09/19/13, 08:38

  5. Mr. Jenkins commented on patch set 3 09/19/13, 08:59

  6. Markus Klein commented on patch set 2 09/19/13, 09:35

    RecordList.php:190

    No space after cast.

    RecordList.php:320

    ... or _the_ root page is...

    AbstractDatabaseRecordList.php:936

    since 6.2
  7. Markus Klein commented on patch set 3 09/19/13, 09:36

    My comments from patch set 2 are still valid.
  8. Jigal van Hemert commented on patch set 3 V -1 CR -1 09/20/13, 08:41

    Collection of page IDs is incorrect.
    The commit message describes the problem, not really the change itself. The name of the function is more or less irrelevant, but the new behaviour should be mentioned here.

    RecordList.php:190

    space, or intval()

    AbstractDatabaseRecordList.php:936

    Deprecated since 6.2, will be removed 2 versions later.

    AbstractDatabaseRecordList.php:971

    The + (union) operator on arrays will only add items to the array if their *key* doesn't exist yet in the left hand array. array_merge() should be used here.

    AbstractDatabaseRecordList.php:978

    Also array_merge()
  9. Jigal van Hemert uploaded patch set 4 09/20/13, 13:05

  10. Jigal van Hemert voted on patch set 4 V +1 CR +1 09/20/13, 13:07

  11. Mr. Jenkins commented on patch set 4 09/20/13, 13:16

  12. Markus Klein commented on patch set 4 09/20/13, 15:03

    AbstractDatabaseRecordList.php:971

    Why is here no if($depth)?

    AbstractDatabaseRecordList.php:979

    I suggest to remove code duplication by moving the foreach below the if and simply setting the $allowedMounts to array($id) here.
  13. Jigal van Hemert commented on patch set 4 09/20/13, 18:08

    AbstractDatabaseRecordList.php:971 Reply

    Actually, $depth is currently always > 0. Otherwise this function isn't called anyway :-)

    AbstractDatabaseRecordList.php:979 Reply

    Not really much code duplicated actually, but feel free to push a new set...
  14. Markus Klein uploaded patch set 5 09/20/13, 18:51

  15. Mr. Jenkins commented on patch set 5 09/20/13, 19:01

  16. Jigal van Hemert commented on patch set 5 V +1 CR +1 09/22/13, 12:29

    Minor rearrangement of code.
  17. Georg Ringer voted on patch set 5 V +1 CR +1 10/18/13, 04:06

  18. Georg Ringer voted on patch set 5 V +2 CR +2 10/18/13, 04:06

  19. Georg Ringer merged patch set 6 10/18/13, 04:07