Review TYPO3_6-1 Merged

23911[BUGFIX] Display relations' titles when TCA label field is type inline

Stefan Froemken CR +2 V +2 Easy +1 −0 updated 01/08/14, 15:01

Commit message

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Files 1

Review log 6

  1. Stefan Froemken uploaded patch set 2 09/19/13, 13:26

  2. Stefan Froemken uploaded patch set 3 09/19/13, 13:28

  3. Oliver Hader commented on patch set 3 CR -1 09/24/13, 07:50

    "select" and "inline" are similar in some cases, but not identical. Currently the patch supports 1n:CSV, 1n:MM, but 1n:FF (foreign_field) is completely missing.
  4. Oliver Hader commented on patch set 3 CR 0 01/08/14, 14:44

    Go ahead. The missing part will be done separately, this way we keep the patches consistent...
  5. Markus Klein voted on patch set 3 V +2 CR +2 01/08/14, 15:01

  6. Markus Klein merged patch set 4 01/08/14, 15:01