Review main Merged

23951[BUGFIX] Fluid tries to render folders as templates partials and layouts

Krzysztof Adamczyk CR +2 V +2 Easy +2 −2 updated 10/07/14, 21:37

Commit message

The file_exists checks in TemplateView and StandaloneView are true for
folders. This leads to unrendered partials with resorted paths.
Use is_file instead.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 14

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 09/21/13, 14:07

  2. Krzysztof Adamczyk uploaded patch set 2 09/21/13, 14:23

  3. Mr. Jenkins commented on patch set 2 09/21/13, 14:33

  4. Marc Bastian Heinrichs commented on patch set 2 CR -1 09/21/13, 15:07

    I think here are some things mixed up now. #47188 is for Package TYPO3.Fluid. But this change is submitted for TYPO3.CMS. But in fact it is no forward port, but a new patch to fix a line that was forgotten in change Ib64e180e01d66777bb5b0683cce26d88ec2a9fd6 issue #47186. Right?
  5. Marc Bastian Heinrichs wrote 03/26/14, 11:49

    Topic set to "Fluid".
  6. Frank Nägler commented on patch set 2 09/22/14, 22:15

    No changes for a year, someone is working on this patch?
  7. Anja Leichsenring uploaded patch set 3 10/03/14, 19:00

  8. Frans Saris commented on patch set 3 10/03/14, 20:08

    TemplateView.php:473

    Is it save to drop the @?
  9. Anja Leichsenring commented on patch set 3 10/04/14, 07:22

    TemplateView.php:473 Reply

    was the only one around, so I tend to drop it, too. It is bad style anyway.
  10. Wouter Wolters updated the commit message in patch set 4 10/07/14, 19:48

  11. Wouter Wolters commented on patch set 4 V +1 CR +1 10/07/14, 19:48

    Code is exactly the same as in TYPO3 Fluid package.
  12. Markus Klein voted on patch set 4 CR +2 V +2 10/07/14, 21:36

  13. Markus Klein merged patch set 4 10/07/14, 21:37

  14. Markus Klein commented on patch set 5 10/07/14, 21:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit d21e9ef089a0ae96b68fe2bd7a15ca1bbea0c450