Review main Abandoned

23953[WIP][FEATURE] Add brute force protection to TYPO3 backend

Torben Hansen CR 0 V 0 Normal +142 −1 updated 11/24/13, 21:53

Commit message

TYPO3 misses a brute force protection for the backend login. Login
attempts for remote attackers should be temporarily disabled, if a
configurable amount of login failures is reached.

Note: This patch is not completely finished and should be seen as
a discussion base (Core members/security team) for this new feature
in TYPO3.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 13

  1. Mr. Jenkins commented on patch set 1 09/22/13, 05:27

  2. Philipp Gampe commented on patch set 1 09/22/13, 08:46

    LoginController.php:218

    IMHO too late

    LoginController.php:222

    l10n

    AbstractUserAuthentication.php:614

    don't throw an exception, the user will not see it anyway as only the people in devIpMask can see the error message (unless TYPO3 is in dev mode).

    IpUtility.php:49

    it should return bool, but you return string!

    IpUtility.php:95

    exec_SELECTgetSingleRow

    IpUtility.php:107

    don't do this every time, use something like rand(0, 100) === 0, to only call this every ~100 calls.
  3. Markus Klein updated the commit message in patch set 1 09/22/13, 10:26

  4. Mr. Jenkins commented on patch set 2 09/22/13, 10:37

  5. Mr. Jenkins commented on patch set 2 09/22/13, 12:05

  6. Marcus Krause commented on patch set 2 CR -1 09/22/13, 12:15

    Please refer to my comments on code in the forge issue itself: http://forge.typo3.org/issues/52170#note-3
  7. Mr. Jenkins commented on patch set 2 09/22/13, 13:27

  8. Mr. Jenkins commented on patch set 2 09/25/13, 18:29

  9. Mr. Jenkins commented on patch set 2 09/25/13, 18:54

  10. Mr. Jenkins commented on patch set 2 CR -1 V -1 09/25/13, 19:09

  11. Mr. Jenkins commented on patch set 2 09/25/13, 19:25

  12. Mr. Jenkins commented on patch set 2 09/25/13, 19:59

  13. Wouter Wolters abandoned the change 11/24/13, 21:53

    The Forge tickets has been closed on authors request. So I will do it now for this review request.