23953[WIP][FEATURE] Add brute force protection to TYPO3 backend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 13
-
Mr. Jenkins commented on patch set 1 09/22/13, 05:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10867/ : SUCCESS -
Philipp Gampe commented on patch set 1 09/22/13, 08:46
LoginController.php:218IMHO too lateLoginController.php:222l10nAbstractUserAuthentication.php:614don't throw an exception, the user will not see it anyway as only the people in devIpMask can see the error message (unless TYPO3 is in dev mode).IpUtility.php:49it should return bool, but you return string!IpUtility.php:95exec_SELECTgetSingleRowIpUtility.php:107don't do this every time, use something like rand(0, 100) === 0, to only call this every ~100 calls. -
Markus Klein updated the commit message in patch set 1 09/22/13, 10:26
-
Mr. Jenkins commented on patch set 2 09/22/13, 10:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10870/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/13, 12:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10871/ : SUCCESS -
Marcus Krause commented on patch set 2 CR -1 09/22/13, 12:15
Please refer to my comments on code in the forge issue itself: http://forge.typo3.org/issues/52170#note-3 -
Mr. Jenkins commented on patch set 2 09/22/13, 13:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10872/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/25/13, 18:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10933/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/25/13, 18:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10934/ : SUCCESS -
Mr. Jenkins commented on patch set 2 CR -1 V -1 09/25/13, 19:09
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/10935/ : FAILURE -
Mr. Jenkins commented on patch set 2 09/25/13, 19:25
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/10936/ : FAILURE -
Mr. Jenkins commented on patch set 2 09/25/13, 19:59
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/10938/ : FAILURE -
Wouter Wolters abandoned the change 11/24/13, 21:53
The Forge tickets has been closed on authors request. So I will do it now for this review request.