Review main Merged

23954[BUGFIX] Prevent leading space for empty ATagParams

Alexander Stehlik CR +2 V +2 Easy +33 −0 updated 09/23/13, 21:49

Commit message

Currently a leading space will be returned by the ATagParams handler when
the $addGlobal parameter is TRUE.

This patch trims any space if no ATagParams have been configured.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 8

  1. Mr. Jenkins commented on patch set 1 09/22/13, 09:19

  2. Philipp Gampe commented on patch set 1 09/22/13, 12:44

    please include all affected versions, at least all 6.x; ask RM if they want it in 4.x (if effected)

    ContentObjectRenderer.php:1616

    please do not use an early return just before the return
  3. Wouter Wolters uploaded patch set 2 09/23/13, 19:40

  4. Alexander Stehlik commented on patch set 2 09/23/13, 19:50

    Thanks for the update Wouter! @Philipp: Since this is only a cosmetic issue (see issue description in forge) it may be sufficient to release it in 6.2. What do you think? We could also change the type from "Bugfix" to "Task" since it is does not cause any errors.
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/23/13, 19:53

  6. Mr. Jenkins commented on patch set 2 09/23/13, 20:05

  7. Stefan Neufeind voted on patch set 2 V +2 CR +2 09/23/13, 21:49

  8. Stefan Neufeind merged patch set 3 09/23/13, 21:49