Review main Merged

24001[BUGFIX] Using ext:sys_action gives a warning about not valid HTML

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 09/24/13, 03:17

Commit message

When ext:sys_action is installed it will give a warning about
not valid HTML. This is because the id="" and class="" are glued
to each other. Fix this by moving the space from the front to the
back.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 4

  1. Wouter Wolters commented on patch set 1 09/23/13, 21:11

    To check have a look at line: 299 of BackendController, the id part is rendered before the class and that leads to this problem.
  2. Mr. Jenkins commented on patch set 1 09/23/13, 21:20

  3. Georg Ringer commented on patch set 1 V +2 CR +2 09/24/13, 03:17

    nobrainer
  4. Georg Ringer merged patch set 2 09/24/13, 03:17