Review main Merged

24038[BUGFIX] Remove duplicate exception code

Fabien Udriot CR +2 V +2 Easy +1 −1 updated 09/25/13, 11:03

Commit message

Exception code "1314354065" is used twice: once in the abstract
Resource repository and the other one in the File Collection repository.
Since exception code must be unique, the patch simply renames one
occurrence.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Kilian Hann +1
  • Verified V +2
    • Xavier Perseguers +2
    • Kilian Hann +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 09/25/13, 08:09

  2. Markus Klein updated the commit message in patch set 1 09/25/13, 09:18

  3. Markus Klein rebased onto patch set 2 09/25/13, 09:19

  4. Markus Klein commented on patch set 3 CR -1 09/25/13, 09:19

    Your git is not clean. You introduced a dependency
  5. Markus Klein uploaded patch set 4 09/25/13, 09:21

  6. Kilian Hann voted on patch set 4 V +1 CR +1 09/25/13, 09:38

  7. Mr. Jenkins commented on patch set 2 09/25/13, 09:41

  8. Mr. Jenkins commented on patch set 3 09/25/13, 09:52

  9. Mr. Jenkins commented on patch set 4 09/25/13, 10:02

  10. Xavier Perseguers commented on patch set 4 V +2 CR +2 09/25/13, 11:03

    - Double-checked source code to ensure the new code was not already in use - Checked http://typo3.org/go/exception/CMS/debug/1314354065 to see if extended exception report has been provided (=> NO)
  11. Xavier Perseguers merged patch set 5 09/25/13, 11:03