Review main Merged

24050[BUGFIX] groupFor-VH does not work with @lazy

Stefan Froemken CR +2 V +2 Easy +3 −0 updated 09/26/13, 21:26

Commit message

If you group an property with annotated @lazy option
f:groupedFor-ViewHelper can't group by this property.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • Xavier Perseguers +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 09/25/13, 14:03

  2. Christian Kuhn commented on patch set 1 09/25/13, 15:01

    i'm unsure if easily possible, should we create a unit test for this?
  3. Xavier Perseguers voted on patch set 1 CR +1 09/25/13, 15:45

  4. Stefan Froemken commented on patch set 1 09/26/13, 06:22

    @CK: Sorry, but there are too less examples in extbase and fluid UnitTests that I can't produce a special test for lazy object integration. Please accept this patch without UnitTest or find someone else who is familiar with lazy objects.
  5. Christian Kuhn voted on patch set 1 V +1 CR +1 09/26/13, 21:10

  6. Wouter Wolters voted on patch set 1 V +2 CR +2 09/26/13, 21:26

  7. Wouter Wolters merged patch set 2 09/26/13, 21:26

  8. Wouter Wolters commented on patch set 2 09/26/13, 21:26

    Cherry Picked This patchset was cherry picked to change: Ie208b67eec8500fee87ee1c62b1bd348c0ed5598
  9. Wouter Wolters commented on patch set 2 09/26/13, 21:26

    Cherry Picked This patchset was cherry picked to change: Ie208b67eec8500fee87ee1c62b1bd348c0ed5598