24057[BUGFIX] Alternative implementations for view helpers do not work
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Markus Klein +1
-
Verified V +2
- Oliver Hader +2
- Markus Klein +1
Files 1
Review log 32
Show 7 earlier messages
-
Mr. Jenkins commented on patch set 1 09/25/13, 16:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10930/ : SUCCESS -
Mr. Jenkins commented on patch set 1 09/25/13, 18:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10931/ : SUCCESS -
Mr. Jenkins commented on patch set 1 09/25/13, 18:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10932/ : SUCCESS -
Christian Kuhn commented on patch set 1 09/26/13, 20:51
? Sry I don't get it. -
Markus Klein uploaded patch set 2 09/26/13, 22:25
-
Mr. Jenkins commented on patch set 2 09/26/13, 22:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10961/ : SUCCESS -
Oliver Hader uploaded patch set 3 09/27/13, 08:33
-
Oliver Hader commented on patch set 3 09/27/13, 08:33
I've added a description to http://forge.typo3.org/issues/52272#note-3 and extended the unit-tests... -
Mr. Jenkins commented on patch set 3 09/27/13, 08:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10972/ : SUCCESS -
Marc Bastian Heinrichs wrote 10/21/13, 18:19
Topic set to "fluid". -
Markus Klein rebased onto patch set 3 01/16/14, 22:10
-
Markus Klein voted on patch set 4 CR +1 01/16/14, 22:12
-
Mr. Jenkins commented on patch set 4 01/16/14, 22:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13060/ : SUCCESS -
Wouter Wolters commented on patch set 4 CR -1 02/05/14, 16:43
Working on an updateTemplateParserTest.php:472Fatal error on this line.TemplateParserTest.php:497fatal error on this line -
Wouter Wolters uploaded patch set 5 02/05/14, 16:49
-
Wouter Wolters commented on patch set 5 V +1 CR +1 02/05/14, 16:53
Verified is based on the unit-tests -
Marc Bastian Heinrichs commented on patch set 5 02/05/14, 17:00
Won't it be possible to do the following in initializeViewHelperAndAddItToStack to save the additional objectmanager->get()? Add the resolved view helper name mapping to the class name of the object returned from object manager to a additonal stack, which could be compared in closingViewHelperTagHandler. -
Mr. Jenkins commented on patch set 5 02/05/14, 17:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13734/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13733/ : SUCCESS -
Markus Klein commented on patch set 5 CR +1 02/11/14, 23:57
@MaBa I'm not sure what you mean exactly, but could you provide such a solution. Saving an obejectmanager call is definitely worth looking for some other solutino. -
Marc Bastian Heinrichs uploaded patch set 6 02/15/14, 10:30
-
Marc Bastian Heinrichs commented on patch set 6 02/15/14, 10:33
Here is my proposal. No test until now. Perhaps anybody has an idea how to nicely test this. -
Mr. Jenkins commented on patch set 6 02/15/14, 10:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14071/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14070/ : SUCCESS -
Markus Klein commented on patch set 6 02/15/14, 17:54
At first glance this looks promising, but I've to look at it again.TemplateParser.php:273Holy sh**. one needs to study English for reading this name... ;-) -
Markus Klein voted on patch set 6 V +1 CR +1 03/18/14, 13:09
-
Stefan Neufeind commented on patch set 6 03/21/14, 23:00
viewhelpers (one word) afaik - here and below does => do -
Markus Klein commented on patch set 6 03/26/14, 21:00
Reply
Done -
Markus Klein updated the commit message in patch set 6 03/26/14, 21:00
-
Markus Klein voted on patch set 7 V +1 CR +1 03/26/14, 21:01
-
Mr. Jenkins commented on patch set 7 03/26/14, 21:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15760/ : SUCCESS -
Oliver Hader commented on patch set 7 V +2 CR +2 05/23/14, 08:12
Perfect, looks much better now compared to my initial approach. Tested in 6.2 and 6.1 - 6.0 will follow -
Oliver Hader merged patch set 8 05/23/14, 08:12
-
Oliver Hader commented on patch set 8 05/23/14, 08:12
Cherry Picked This patchset was cherry picked to change: Ie49e5e83c779b4748dc2059f8fbc85552ce4b406