24071[BUGFIX] Correct storage selection (follow-up)
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Steffen Ritter +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Stefan Neufeind +2
- Steffen Ritter +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 14
-
Mr. Jenkins commented on patch set 1 09/26/13, 14:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10950/ : SUCCESS -
Steffen Ritter voted on patch set 1 CR +1 09/26/13, 15:06
-
Markus Klein voted on patch set 1 CR +1 09/26/13, 15:45
-
Wouter Wolters voted on patch set 1 CR +1 10/01/13, 20:56
-
Philipp Gampe commented on patch set 1 V +1 CR +1 10/04/13, 17:08
tested with unit test -
Stefan Neufeind commented on patch set 1 10/04/13, 17:47
ResourceFactory.php:186Sorry if this is a dum question: But if you look for a "common prefix", how can the match be *longer* than strlen of the basePath? DO we need that additional check in the if here? -
Markus Klein commented on patch set 1 CR 0 10/05/13, 13:48
ResourceFactory.php:186ReplyHm, very good point. I've to re-evaluate this again. removing my vote. -
Stefan Neufeind commented on patch set 1 CR -1 10/14/13, 22:59
see inline-comment. imho there is one check too much (not needed) -
Wouter Wolters wrote 10/16/13, 18:06
Topic set to "fal". -
Steffen Ritter commented on patch set 1 V +2 CR +2 11/09/13, 15:37
ResourceFactory.php:186Replybecause for another storage the match already was more precise storage0: basePath / storage1: basePath /fileadmin/ storage5: basePath /fileadmin/my/specialmount/ if file is in special mount - than the match can be longer then the base path... this is fine -
Stefan Neufeind voted on patch set 1 V +2 CR +2 11/09/13, 15:44
-
Stefan Neufeind merged patch set 2 11/09/13, 15:44
-
Stefan Neufeind commented on patch set 2 11/09/13, 15:45
Cherry Picked This patchset was cherry picked to change: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27 -
Stefan Neufeind commented on patch set 2 11/09/13, 15:45
Cherry Picked This patchset was cherry picked to change: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27