Review main Merged

24071[BUGFIX] Correct storage selection (follow-up)

Ernesto Baschny CR +2 V +2 Easy +8 −5 updated 11/09/13, 15:45

Commit message

The new matching did not consider Windows paths names as the
previous version did. Using PathUtility is safer.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 14

  1. Mr. Jenkins commented on patch set 1 09/26/13, 14:58

  2. Steffen Ritter voted on patch set 1 CR +1 09/26/13, 15:06

  3. Markus Klein voted on patch set 1 CR +1 09/26/13, 15:45

  4. Wouter Wolters voted on patch set 1 CR +1 10/01/13, 20:56

  5. Philipp Gampe commented on patch set 1 V +1 CR +1 10/04/13, 17:08

    tested with unit test
  6. Stefan Neufeind commented on patch set 1 10/04/13, 17:47

    ResourceFactory.php:186

    Sorry if this is a dum question: But if you look for a "common prefix", how can the match be *longer* than strlen of the basePath? DO we need that additional check in the if here?
  7. Markus Klein commented on patch set 1 CR 0 10/05/13, 13:48

    ResourceFactory.php:186 Reply

    Hm, very good point. I've to re-evaluate this again. removing my vote.
  8. Stefan Neufeind commented on patch set 1 CR -1 10/14/13, 22:59

    see inline-comment. imho there is one check too much (not needed)
  9. Wouter Wolters wrote 10/16/13, 18:06

    Topic set to "fal".
  10. Steffen Ritter commented on patch set 1 V +2 CR +2 11/09/13, 15:37

    ResourceFactory.php:186 Reply

    because for another storage the match already was more precise storage0: basePath / storage1: basePath /fileadmin/ storage5: basePath /fileadmin/my/specialmount/ if file is in special mount - than the match can be longer then the base path... this is fine
  11. Stefan Neufeind voted on patch set 1 V +2 CR +2 11/09/13, 15:44

  12. Stefan Neufeind merged patch set 2 11/09/13, 15:44

  13. Stefan Neufeind commented on patch set 2 11/09/13, 15:45

    Cherry Picked This patchset was cherry picked to change: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27
  14. Stefan Neufeind commented on patch set 2 11/09/13, 15:45

    Cherry Picked This patchset was cherry picked to change: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27