Review main Merged

24131[TASK] Make use of autoloading for fixtures in testclasses

Stefan Neufeind CR +2 V +2 Normal +24 −155 updated 10/12/13, 19:51

Commit message

Autoloader can be used in almost all cases.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 75

Show 55 more files

Review log 8

  1. Mr. Jenkins commented on patch set 1 09/28/13, 20:58

  2. Christian Kuhn commented on patch set 1 09/29/13, 20:00

    I'm not 100% sure if that works. Imho the autoloader is *not* constructed to find classes within Tests/Unit directly. But I think phpunit reads all files within a folderStructure and requires them probably, if *not* a single test class is given as argument. So, I'd guess the requires are needed as soon as you execute a single test or a single test suite, because the "scan" of phpunit does not happen then ... this is a guess, needs to be checked. If true, the require statements need to stay.
  3. Christian Kuhn commented on patch set 1 10/11/13, 09:52

    Ok, found out the opposite of what I wrote above: If the namespace is correct, our autoloader *will* find fixture classes automatically, so the patch should be ok.
  4. Stefan Neufeind commented on patch set 1 10/12/13, 01:48

    Great :-) So could you maybe give the patch a spin?
  5. Christian Kuhn uploaded patch set 2 10/12/13, 17:35

  6. Christian Kuhn commented on patch set 2 V +2 CR +2 10/12/13, 17:38

    Ok, very nice, thx! Just rebased, some trivial changes. I'll merge this cleanup now.
  7. Christian Kuhn merged patch set 3 10/12/13, 17:38

  8. Mr. Jenkins commented on patch set 2 10/12/13, 19:51