24131[TASK] Make use of autoloading for fixtures in testclasses
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 75
- typo3/sysext/core/Tests/Unit/Cache/FactoryTest.php+0 −2
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+0 −2
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+1 −3
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/AbstractTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractDriverTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Utility/MathUtilityTest.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMapperTest.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationBuilderTest.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Scheduler/Fixtures/MockACommandController.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Scheduler/TaskExecutorTest.phprenamed+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BooleanValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/EmailAddressValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php+1 −2
Show 55 more files
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberRangeValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/RawValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/RegularExpressionValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/TextValidatorTest.php+1 −2
- typo3/sysext/fluid/Tests/Unit/Core/Parser/Fixtures/ChildNodeAccessFacetViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Parser/Fixtures/PostParseFacetViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Parser/SyntaxTree/ViewHelperNodeTest.php+1 −4
- typo3/sysext/fluid/Tests/Unit/Core/Parser/TemplateParserTest.php+2 −4
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractConditionViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/ViewHelperVariableContainerTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/IfAuthenticatedViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/IfHasRoleViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/UserDomainClass.phprenamed+0 −0
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/ButtonViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/FormFieldViewHelperBaseTestcase.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/PasswordViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SubmitViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextareaViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextfieldViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/UploadViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/ExternalViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/PageViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Security/IfAuthenticatedViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Security/IfHasRoleViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/EmailViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/ExternalViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/AliasViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/BaseViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CaseViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CountViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CycleViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ElseViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FlashMessagesViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ForViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/GroupedForViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/IfViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/RenderChildrenViewHelperTest.php+0 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/RenderViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/SwitchViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ThenViewHelperTest.php+0 −2
Review log 8
-
Mr. Jenkins commented on patch set 1 09/28/13, 20:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11003/ : SUCCESS -
Christian Kuhn commented on patch set 1 09/29/13, 20:00
I'm not 100% sure if that works. Imho the autoloader is *not* constructed to find classes within Tests/Unit directly. But I think phpunit reads all files within a folderStructure and requires them probably, if *not* a single test class is given as argument. So, I'd guess the requires are needed as soon as you execute a single test or a single test suite, because the "scan" of phpunit does not happen then ... this is a guess, needs to be checked. If true, the require statements need to stay. -
Christian Kuhn commented on patch set 1 10/11/13, 09:52
Ok, found out the opposite of what I wrote above: If the namespace is correct, our autoloader *will* find fixture classes automatically, so the patch should be ok. -
Stefan Neufeind commented on patch set 1 10/12/13, 01:48
Great :-) So could you maybe give the patch a spin? -
Christian Kuhn uploaded patch set 2 10/12/13, 17:35
-
Christian Kuhn commented on patch set 2 V +2 CR +2 10/12/13, 17:38
Ok, very nice, thx! Just rebased, some trivial changes. I'll merge this cleanup now. -
Christian Kuhn merged patch set 3 10/12/13, 17:38
-
Mr. Jenkins commented on patch set 2 10/12/13, 19:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11363/ : SUCCESS