Review main Merged

24257[TASK] Use instanceof comparison instead of string comparison

Benjamin Serfhos CR +2 V +2 Easy +1 −1 updated 10/05/13, 13:15

Commit message

This allows the ViewHelper to render elements which are extending
the model.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 16

  1. Markus Klein updated the commit message in patch set 1 10/02/13, 12:39

  2. Markus Klein updated the commit message in patch set 2 10/02/13, 12:42

  3. Markus Klein commented on patch set 3 V +1 CR +1 10/02/13, 12:42

    6.0 is affected too
  4. Mr. Jenkins commented on patch set 1 10/02/13, 12:44

  5. Mr. Jenkins commented on patch set 2 10/02/13, 12:57

  6. Mr. Jenkins commented on patch set 3 10/02/13, 13:08

  7. Christian Kuhn commented on patch set 3 10/03/13, 01:44

    Maybe specify a more specific commit message header line?
  8. Philipp Gampe commented on patch set 3 10/04/13, 17:00

    what is the part with the @0h:10?
  9. Wouter Wolters updated the commit message in patch set 3 10/04/13, 17:07

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 10/04/13, 17:16

  11. Mr. Jenkins commented on patch set 4 10/04/13, 17:20

  12. Markus Klein commented on patch set 3 10/05/13, 13:14

  13. Markus Klein voted on patch set 4 V +1 CR +1 10/05/13, 13:15

  14. Markus Klein voted on patch set 4 V +2 CR +2 10/05/13, 13:15

  15. Markus Klein merged patch set 5 10/05/13, 13:15

  16. Markus Klein commented on patch set 5 10/05/13, 13:15

    Cherry Picked This patchset was cherry picked to change: If4b9b3019b44e38a5a25cb74ff993e572464bb9d