Review main Merged

24349[TASK] Redesign "about modules" as start screen

Felix Kopp CR +2 V +2 Normal +31 −46 updated 10/06/13, 18:28

Commit message

Adds visual containers for icons on about modules for
easier access. About Modules will be the start screen.

Also extends the width of the module.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 10

  1. Mr. Jenkins commented on patch set 1 10/03/13, 21:08

  2. Ingo Pfennigstorf commented on patch set 1 V +1 CR +1 10/03/13, 21:14

    Nice one … Much better and flatter. The only thing I personally dislike is the hover thing on the icon boxes
  3. Felix Kopp commented on patch set 1 10/03/13, 21:26

    Is the same coloring as on module menu on the left. I think we need some kind of visual feedback since the containers are buttons. What might be better?
  4. Xavier Perseguers commented on patch set 1 V +1 CR +1 10/04/13, 07:48

    The hovering is fine I'd say but the height of the box makes it rectangular instead of (expected) square. But perhaps it's related to one of your other CSS patches
  5. Philipp Gampe commented on patch set 1 10/04/13, 15:23

    It looks a bit strange on my system (Chrome on Linux): http://dl.dropbox.com/u/4879710/2013-10-04-TYPO3%5BTYPO36.2-dev%5D-GoogleChrome-002.png The icons are not centered. Also I think the whole module is too far left. Also, I expected that the whole text is clickable, whereas only the title and the icons is.
  6. Wouter Wolters commented on patch set 1 V +1 CR +1 10/05/13, 11:38

    Other modules are also to the left with exact the same width. The centering of the icons can be done with adjusting the line-height on the icon. But not a blocker for me.
  7. Christian Kuhn uploaded patch set 2 10/06/13, 18:16

  8. Christian Kuhn commented on patch set 2 V +2 CR +2 10/06/13, 18:17

    Just fixed a CGL details. Merged taking previous votes into account.
  9. Christian Kuhn merged patch set 3 10/06/13, 18:17

  10. Mr. Jenkins commented on patch set 2 10/06/13, 18:28