Review main Merged

24419[TASK] Load defaultConfigArray just once in AllConfiguration

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 10/05/13, 20:47

Commit message

Currently the method getDefaultConfigArrayComments is
called for every setting but should only be called once.
The method parses the whole defaultconfiguration file so
maybe this does speed up things a little bit.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 3

  1. Markus Klein commented on patch set 1 V +2 CR +2 10/05/13, 20:41

    no-brainer! good catch.
  2. Markus Klein merged patch set 2 10/05/13, 20:41

  3. Mr. Jenkins commented on patch set 1 10/05/13, 20:47