Review main Merged

2446[BUGFIX] Scheduler: use img title-tags for mouse-over at status legend

Andy Grunwald CR +2 V +2 Easy +6 −7 updated 06/03/13, 20:49

Commit message

The 'Status Legend' in the Scheduler backend module does not use
<img title="" /> tags. Only <img alt=""> tags.
This patch writes the value from alt=""-Tag to title="" tag.

Thanks to Qitec for the original patch.

Review

  • Code review CR +2
    • Francois Suter +2
    • Andy Grunwald +1
  • Verified V +2
    • Francois Suter +2
    • Andy Grunwald +1

Issues 1

Files 1

Review log 17

  1. Andy Grunwald uploaded patch set 2 05/31/11, 11:29

  2. Francois Suter uploaded patch set 4 05/31/11, 11:29

  3. Francois Suter commented on patch set 4 05/31/11, 11:29

    Verified; Looks good to me, but someone else must approve $executionStatusDetail was not used at all actually. This new version of the patch removes it entirely.
  4. Xavier Perseguers commented on patch set 3 05/31/11, 11:29

    (3 inline comments)
    nitpicking: invalid single quote in "don't"
    "Thanks" please
    Info duplicated with "Releases" info and hints for backporting it should only be part of Forge comments.
  5. Andy Grunwald uploaded patch set 3 05/31/11, 11:29

  6. Francois Suter uploaded patch set 6 05/31/11, 11:29

  7. Francois Suter commented on patch set 6 05/31/11, 11:29

    While testing I thought that it would be better to use the longer label from the status legend for the icon in the task list (not inside the legend, obviously). What do you think?
  8. Francois Suter commented on patch set 6 V 0 05/31/11, 11:29

    by team member; Looks good to me, approved
  9. Andy Grunwald uploaded patch set 5 05/31/11, 11:29

  10. Andy Grunwald commented on patch set 6 05/31/11, 11:29

    Verified; Looks good to me, but someone else must approve I like the idea. I`ve talked with Francois about the idea to change the titles ob the legend icons to the long labels to. We came to the conclusion that this would be a kind of redundance. On the other hand, we have different labes for the same icons. But all in all it is nitpicking. I like the idea of Francois, so i voted my +1 (testing and reading). Thanks Francois for your help.
  11. Mr. Jenkins commented on patch set 1 05/31/11, 11:29

  12. Mr. Jenkins commented on patch set 2 05/31/11, 11:29

  13. Mr. Jenkins commented on patch set 3 05/31/11, 11:29

  14. Mr. Jenkins commented on patch set 4 05/31/11, 11:29

  15. Mr. Jenkins commented on patch set 5 05/31/11, 11:29

  16. Mr. Jenkins commented on patch set 6 05/31/11, 11:29

  17. Francois Suter merged patch set 6 05/31/11, 11:29