Review main Merged

24460[FEATURE] Add hook to custom header in page mod

Eric Chavaillaz CR +2 V +2 Easy +10 −0 updated 10/08/13, 19:57

Commit message

Add an hook to allow modifying the header of a page in the page module.
This hook is called before the content of the page is rendered.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Huf +1
    • Xavier Perseguers +1
  • Verified V +2
    • Christian Kuhn +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 10/07/13, 16:14

  2. Daniel Huf commented on patch set 1 CR +1 10/07/13, 17:48

    Thanks Eric
  3. Xavier Perseguers voted on patch set 1 V +1 CR +1 10/07/13, 20:41

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 10/08/13, 19:57

    This looks like a logic addition to the existing 'drawFooterHook'.
  5. Christian Kuhn merged patch set 2 10/08/13, 19:57