Review main Merged

24462[TASK] Deprecate insertModuleFunction "$classPath" parameter

Ernesto Baschny CR +2 V +2 Normal +61 −47 updated 03/08/14, 16:36

Commit message

Deprecates the need to specify the $classPath when registering a submodule
with ExtensionManagementUtility::insertModuleFunction. Remove the
parameter's usage throughout the system extensions.

Also re-adds the removed include_once that were removed without proper
deprecation before (see #49992).

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 22

Review log 26

Show 1 earlier messages
  1. Ernesto Baschny commented on patch set 1 10/07/13, 17:04

    AbstractFunctionModule.php:200

    In the past, the passed on 'path' was used also to find related "locallang.php" files. Thus I changed it to find the path for the class using reflection instead.

    index.php:51

    These are re-added to provide backwards compatibility which was removed by accident in #49992.

    RecordList.php:158

    RecordList is no subclass of BaseScriptClass, and never once uses this include_once array.

    index.php:46

    RecordList never sets include_once and thus this was useless anyway. So we can remove it
  1. Mr. Jenkins commented on patch set 1 10/07/13, 17:11

  2. Wouter Wolters updated the commit message in patch set 1 10/15/13, 21:21

  3. Wouter Wolters uploaded patch set 3 10/15/13, 21:25

  4. Wouter Wolters uploaded patch set 4 10/15/13, 21:29

  5. Wouter Wolters commented on patch set 4 CR +1 10/15/13, 21:30

    Replaced some deprecated notation to have a @ in front of it.
  6. Wouter Wolters wrote 10/15/13, 21:30

    Topic set to "deprecation".
  7. Mr. Jenkins commented on patch set 2 10/16/13, 01:28

  8. Mr. Jenkins commented on patch set 3 10/16/13, 01:41

  9. Mr. Jenkins commented on patch set 4 10/16/13, 01:54

  10. Wouter Wolters commented on patch set 4 11/24/13, 21:57

    ping
  11. Wouter Wolters uploaded patch set 5 01/28/14, 21:45

  12. Wouter Wolters voted on patch set 5 V +1 CR +1 01/28/14, 21:46

  13. Mr. Jenkins commented on patch set 5 01/28/14, 21:58

  14. Wouter Wolters uploaded patch set 6 03/08/14, 15:01

  15. Wouter Wolters uploaded patch set 7 03/08/14, 15:02

  16. Wouter Wolters commented on patch set 7 V +1 CR +1 03/08/14, 15:02

    rebased
  17. Mr. Jenkins commented on patch set 6 03/08/14, 15:21

  18. Mr. Jenkins commented on patch set 7 03/08/14, 15:24

  19. Christian Kuhn commented on patch set 7 V -1 03/08/14, 15:40

    kills at least 2 modules for me: info -> indexed search statistics func -> sort pages
  20. Christian Kuhn commented on patch set 7 03/08/14, 15:45

    investigating ...
  21. Christian Kuhn uploaded patch set 8 03/08/14, 16:23

  22. Christian Kuhn commented on patch set 8 V +1 CR +1 03/08/14, 16:25

    * fixed a typo in registration of wizard sortpages * properly load indexed_search locallang now and remove the old class* files. looks good to me now.
  23. Anja Leichsenring voted on patch set 8 V +2 CR +2 03/08/14, 16:30

  24. Anja Leichsenring merged patch set 9 03/08/14, 16:30

  25. Mr. Jenkins commented on patch set 8 03/08/14, 16:36