24462[TASK] Deprecate insertModuleFunction "$classPath" parameter
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 22
- typo3/sysext/backend/Classes/Module/AbstractFunctionModule.php1+5 −2
- typo3/sysext/backend/Classes/Module/BaseScriptClass.php+3 −0
- typo3/sysext/belog/ext_tables.php+1 −1
- typo3/sysext/cms/ext_tables.php+2 −2
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+9 −1
- typo3/sysext/func/mod1/index.php+2 −0
- typo3/sysext/func_wizards/ext_tables.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+7 −0
- typo3/sysext/indexed_search/Classes/Controller/IndexingStatisticsController.php+7 −0
- typo3/sysext/indexed_search/modfunc1/class.tx_indexedsearch_modfunc1.phpdeleted+0 −9
- typo3/sysext/indexed_search/modfunc2/class.tx_indexedsearch_modfunc2.phpdeleted+0 −9
- typo3/sysext/indexed_search/ext_tables.php+2 −2
- typo3/sysext/info/mod1/index.php1+10 −0
- typo3/sysext/info_pagetsconfig/ext_tables.php+1 −1
- typo3/sysext/linkvalidator/ext_tables.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList.php1+0 −6
- typo3/sysext/recordlist/mod1/index.php1+0 −4
- typo3/sysext/recycler/mod1/index.php+1 −0
- typo3/sysext/scheduler/mod1/index.php+1 −0
- typo3/sysext/tstemplate/ext_tables.php+5 −5
Review log 26
Show 1 earlier messages
-
Ernesto Baschny commented on patch set 1 10/07/13, 17:04
index.php:51These are re-added to provide backwards compatibility which was removed by accident in #49992.RecordList.php:158RecordList is no subclass of BaseScriptClass, and never once uses this include_once array.index.php:46RecordList never sets include_once and thus this was useless anyway. So we can remove it
-
Mr. Jenkins commented on patch set 1 10/07/13, 17:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11157/ : SUCCESS -
Wouter Wolters updated the commit message in patch set 1 10/15/13, 21:21
-
Wouter Wolters uploaded patch set 3 10/15/13, 21:25
-
Wouter Wolters uploaded patch set 4 10/15/13, 21:29
-
Wouter Wolters commented on patch set 4 CR +1 10/15/13, 21:30
Replaced some deprecated notation to have a @ in front of it. -
Wouter Wolters wrote 10/15/13, 21:30
Topic set to "deprecation". -
Mr. Jenkins commented on patch set 2 10/16/13, 01:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11637/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/16/13, 01:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11638/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/16/13, 01:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11639/ : SUCCESS -
Wouter Wolters commented on patch set 4 11/24/13, 21:57
ping -
Wouter Wolters uploaded patch set 5 01/28/14, 21:45
-
Wouter Wolters voted on patch set 5 V +1 CR +1 01/28/14, 21:46
-
Mr. Jenkins commented on patch set 5 01/28/14, 21:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13288/ : SUCCESS -
Wouter Wolters uploaded patch set 6 03/08/14, 15:01
-
Wouter Wolters uploaded patch set 7 03/08/14, 15:02
-
Wouter Wolters commented on patch set 7 V +1 CR +1 03/08/14, 15:02
rebased -
Mr. Jenkins commented on patch set 6 03/08/14, 15:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14712/ : SUCCESS -
Mr. Jenkins commented on patch set 7 03/08/14, 15:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14713/ : SUCCESS -
Christian Kuhn commented on patch set 7 V -1 03/08/14, 15:40
kills at least 2 modules for me: info -> indexed search statistics func -> sort pages -
Christian Kuhn commented on patch set 7 03/08/14, 15:45
investigating ... -
Christian Kuhn uploaded patch set 8 03/08/14, 16:23
-
Christian Kuhn commented on patch set 8 V +1 CR +1 03/08/14, 16:25
* fixed a typo in registration of wizard sortpages * properly load indexed_search locallang now and remove the old class* files. looks good to me now. -
Anja Leichsenring voted on patch set 8 V +2 CR +2 03/08/14, 16:30
-
Anja Leichsenring merged patch set 9 03/08/14, 16:30
-
Mr. Jenkins commented on patch set 8 03/08/14, 16:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14714/ : SUCCESS
AbstractFunctionModule.php:200