Review main Merged

24489[FEATURE] Add autofocus to pass input in install

Eric Chavaillaz CR +2 V +2 Easy +1 −1 updated 10/08/13, 21:37

Commit message

Restore the focus to the password input just after
opening the install tool.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 10/08/13, 17:34

  2. Christian Kuhn uploaded patch set 2 10/08/13, 19:47

  3. Christian Kuhn commented on patch set 2 V +1 CR +1 10/08/13, 19:50

    I removed the JS stuff, imho younger browsers should be the major goal of this 6.2 release.
  4. Mr. Jenkins commented on patch set 2 10/08/13, 20:00

  5. Eric Chavaillaz commented on patch set 2 V -1 10/08/13, 20:33

    Hi Christian, I am not agree with you because the "autofocus" property is not working if you open the install tool directly in the backend. The iframe don't care if it. So the js is required here... "autofocus" property work only if you open the install tool outside of the backend...
  6. Christian Kuhn commented on patch set 2 10/08/13, 21:09

    Hmm, if I tested correctly, the autofocus *did* work in backend context in chrome.
  7. Eric Chavaillaz commented on patch set 2 V 0 10/08/13, 21:20

    Ok. so I will test again in FF and give my feedback...
  8. Helmut Hummel voted on patch set 2 V +2 CR +2 10/08/13, 21:36

  9. Helmut Hummel merged patch set 3 10/08/13, 21:37