Review main Merged

2450[FEATURE][CONF] Options for pages in new record wizard

Francois Suter CR +2 V +2 Normal +54 −24 updated 06/03/13, 20:49

Commit message

Pretty much everything is configurable in the new record wizard
(typo3/db_new.php), except for the three links to create new pages
(after, inside and select position).

This change introduces new Page TSconfig options to that effect.

Review

  • Code review CR +2
    • Francois Suter +2
    • Stefan Neufeind +1
    • Oliver Hader +1
  • Verified V +2
    • Francois Suter +2
    • Stefan Neufeind +1
    • Oliver Hader +1

Issues 1

Files 1

Review log 13

  1. Francois Suter commented on patch set 2 V 0 06/14/11, 07:42

    by team member; Looks good to me, approved Thanks for the reviews.
  2. Francois Suter uploaded patch set 2 06/14/11, 07:42

  3. Francois Suter commented on patch set 2 06/14/11, 07:42

    Thanks for the reviews. The new version of the patch takes care of them. It not only takes care of the missing half-line, but also properly handles the "branch bottom" icon.
  4. Francois Suter merged patch set 2 06/14/11, 07:42

  5. Stefan Neufeind commented on patch set 1 1 comment 06/14/11, 07:42

    Verified; Looks good to me, but someone else must approve Please take care of the comments. Rest is fine.
  6. Stefan Neufeind voted on patch set 2 V 0 06/14/11, 07:42

  7. Stefan Neufeind commented on patch set 2 06/14/11, 07:42

    Looks good to me, but someone else must approve
  8. Oliver Hader commented on patch set 2 06/14/11, 07:42

    Looks good to me, but someone else must approve
  9. Oliver Hader voted on patch set 2 V 0 06/14/11, 07:42

  10. Andy Grunwald commented on patch set 1 06/14/11, 07:42

    Fails Thanks for this possibility. If you configure " mod.wizards.newRecord.pages.show.pageSelectPosition = 0" the space between pages and content elements is missing. At the forge ticket i`ve added a screenshot. This is taken in Firefox 4 on Mac. For the core review, i would prefer if you use the PHP5 visibility features. "var ..." is ugly PHP4 style. The best way is to set this new member variable to protected and create a getter and setter variable. Sorry, at the moment i had no time to create a new patch set.

    db_new.php:123

    Please use PHP5 visbility features (public / private / protected)
  11. Mr. Jenkins commented on patch set 1 06/14/11, 07:42

  12. Mr. Jenkins commented on patch set 2 06/14/11, 07:42