24523[FEATURE] Allow adding multiple CSS files in RTE
Commit message
Review
-
Code review CR +2
- Stanislas Rolland +2
-
Verified V +2
- Stanislas Rolland +2
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-50039-MultipleCssFilesInRte.rst1new+22 −0
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php12+36 −16
- typo3/sysext/rtehtmlarea/Documentation/Configuration/PageTsconfig/interfaceConfiguration/Index.rst+9 −1
- typo3/sysext/rtehtmlarea/htmlarea/Configuration/HTMLArea.Config.js+2 −2
- typo3/sysext/rtehtmlarea/htmlarea/CSS/HTMLArea.CSS.Parser.js+1 −1
- typo3/sysext/rtehtmlarea/htmlarea/Editor/HTMLArea.Iframe.js+10 −11
Review log 28
Show 3 earlier messages
-
Mr. Jenkins commented on patch set 1 10/10/13, 12:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11207/ : SUCCESS -
Philipp Gampe commented on patch set 1 V -1 CR -1 10/10/13, 12:12
Patch misses the compat handling for the old setting. Essentially, you have to add any filename given directly to contentCSS to the array defined in contentCSS. Do to the nature of TypoScript, you do this without hacks.RteHtmlAreaBase.php:544add compat handling for contentCSS = filename here: if (isset($this->thisConfig['contentCSS'])) { $contentCss[] = $this->getContentCssFileName(); }RteHtmlAreaBase.php:547!empty is wrong here ... it should be count() I guess?RteHtmlAreaBase.php:555is_array is not needed, because it is defined above ... you can just check with count() === 0 if the arrays has entriesRteHtmlAreaBase.php:983it is always an array, because you add ['default'] in case it is emptyhtmlarea.js:1045are you sure that this part is not needed? -
Eric Chavaillaz uploaded patch set 2 10/10/13, 12:51
-
Eric Chavaillaz commented on patch set 2 10/10/13, 12:54
For the deleted lines in the js file, I am almost sure because those lines are here to check if a <link> tag is already inserted with the contentCSS property... -
Mr. Jenkins commented on patch set 2 10/10/13, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11209/ : SUCCESS -
Xavier Perseguers commented on patch set 2 10/10/13, 14:28
RteHtmlAreaBase.php:533$contentCssFile (capital F) pleasehtmlarea.js:159Why this comment line again? -
Xavier Perseguers uploaded patch set 3 10/10/13, 14:32
-
Mr. Jenkins commented on patch set 3 10/10/13, 14:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11213/ : SUCCESS -
Eric Chavaillaz commented on patch set 3 10/10/13, 14:54
Thanks Xavier for the corrections. -
Stefan Neufeind commented on patch set 3 CR -1 10/17/13, 14:15
RteHtmlAreaBase.php:543add "array" as type for the return Maybe in the same step also rename to "getContentCssFilenames" or just "...Files"? Those are multiple names/files nowRteHtmlAreaBase.php:544check if that array exists. If not, initialise with an empty arrayRteHtmlAreaBase.php:547maybe just prepend that to the array and further below do an array_unique() for all the entries?RteHtmlAreaBase.php:988you miss the "versionnumbered"-part here (to force the browser to reload a new version of the file) -
Eric Chavaillaz uploaded patch set 4 10/17/13, 15:44
-
Mr. Jenkins commented on patch set 4 10/17/13, 15:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11685/ : SUCCESS -
Stefan Neufeind commented on patch set 4 CR +1 10/17/13, 17:03
Looks okay by reading imhoRteHtmlAreaBase.php:560you could move this if a few lines below and avoid the following else then (actually a "duplication" - sort of). -
Eric Chavaillaz uploaded patch set 5 10/17/13, 17:24
-
Mr. Jenkins commented on patch set 5 10/17/13, 17:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11691/ : SUCCESS -
Stefan Neufeind voted on patch set 5 CR +1 10/17/13, 17:52
-
Krzysztof Adamczyk voted on patch set 5 V +1 CR +1 06/11/14, 14:30
-
Xavier Perseguers commented on patch set 5 06/12/14, 10:06
RteHtmlAreaBase.php:533same here (see below)RteHtmlAreaBase.php:987You should not use the result of a method in a foreach => $contentCssFileNames = $this->getContentCssFileNames(); foreach ($contentCssFileNames as $contentCssFileName) { -
Eric Chavaillaz uploaded patch set 6 06/12/14, 11:38
-
Mr. Jenkins commented on patch set 6 06/12/14, 12:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16688/ : SUCCESS -
Xavier Perseguers uploaded patch set 7 09/21/14, 12:49
-
Xavier Perseguers voted on patch set 7 CR +1 09/21/14, 12:50
-
Stefan Neufeind voted on patch set 7 CR +1 09/21/14, 16:01
-
Stanislas Rolland uploaded patch set 8 10/23/14, 01:55
-
Markus Klein commented on patch set 8 10/23/14, 03:00
Feature-50039-MultipleCssFilesInRte.rst:3these need to be same length as title -
Stanislas Rolland uploaded patch set 9 10/23/14, 12:47
-
Stanislas Rolland voted on patch set 9 CR +2 V +2 10/23/14, 12:48
-
Stanislas Rolland merged patch set 9 10/23/14, 12:48