24524[BUGFIX] Move shutdown function to install class
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 24
-
Mr. Jenkins commented on patch set 1 10/10/13, 13:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11210/ : SUCCESS -
Philipp Gampe voted on patch set 1 CR +1 10/11/13, 23:01
-
Philipp Gampe uploaded patch set 2 10/11/13, 23:36
-
Philipp Gampe commented on patch set 2 V +1 CR +1 10/11/13, 23:37
fixed a small error (add print_r) -
Mr. Jenkins commented on patch set 2 10/11/13, 23:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11305/ : SUCCESS -
Christian Kuhn voted on patch set 2 CR -2 10/12/13, 09:31
-
Nicole Hummel uploaded patch set 3 10/12/13, 10:04
-
Nicole Hummel uploaded patch set 4 10/12/13, 10:06
-
Nicole Hummel commented on patch set 4 10/12/13, 10:07
Moved shutdown function from bootstrap to install.php and rewrite the commit message -
Philipp Gampe voted on patch set 4 V +1 CR +1 10/12/13, 10:13
-
Oliver Klee commented on patch set 4 10/12/13, 10:30
Install.php:115I propose to change this to a guard clause with an early return. This will reduce the indentation level of the big code block by one leve.Install.php:118Maybe here as well. -
Mr. Jenkins commented on patch set 3 10/12/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11316/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/12/13, 10:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11317/ : SUCCESS -
Nicole Hummel commented on patch set 4 10/12/13, 17:52
Install.php:115ReplyI don't get why we should send any return as this is a shutdown function?! -
Oliver Klee commented on patch set 4 10/16/13, 11:17
I'll update the changeset with the guard clauses in a second.Install.php:115ReplyWith "early return", I did not mean "return value", but something like this: if ($error === NULL) { return; } -
Nicole Hummel commented on patch set 4 10/16/13, 11:18
Not sure if we still need that patch?! Christian? -
Oliver Klee uploaded patch set 6 10/16/13, 11:28
-
Oliver Klee commented on patch set 6 10/16/13, 11:29
I've updated the patch to use two guard clauses in order to avoid this deep indentation. I have not tested this patch, though. -
Mr. Jenkins commented on patch set 6 10/16/13, 11:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11646/ : SUCCESS -
Christian Kuhn voted on patch set 6 CR 0 10/16/13, 19:20
-
Wouter Wolters commented on patch set 6 10/16/13, 19:24
Install.php:161totally brokeInstall.php:162extListArray is wrong now.Install.php:163Install ToolInstall.php:164any -> a -
Oliver Klee uploaded patch set 7 10/22/13, 16:39
-
Mr. Jenkins commented on patch set 7 10/22/13, 16:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11773/ : SUCCESS -
Nicole Hummel abandoned the change 03/21/14, 19:51
Superfluous with failsafe package manager