Review main Abandoned

24524[BUGFIX] Move shutdown function to install class

Nicole Hummel CR 0 V 0 Normal +56 −51 updated 03/21/14, 19:51

Commit message

To be able to catch more fatal errors from third party extensions
during install tool initialisation the registration of the shutdown
function is moved from the tool controller to the install class.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 24

  1. Mr. Jenkins commented on patch set 1 10/10/13, 13:14

  2. Philipp Gampe voted on patch set 1 CR +1 10/11/13, 23:01

  3. Philipp Gampe uploaded patch set 2 10/11/13, 23:36

  4. Philipp Gampe commented on patch set 2 V +1 CR +1 10/11/13, 23:37

    fixed a small error (add print_r)
  5. Mr. Jenkins commented on patch set 2 10/11/13, 23:48

  6. Christian Kuhn voted on patch set 2 CR -2 10/12/13, 09:31

  7. Nicole Hummel uploaded patch set 3 10/12/13, 10:04

  8. Nicole Hummel uploaded patch set 4 10/12/13, 10:06

  9. Nicole Hummel commented on patch set 4 10/12/13, 10:07

    Moved shutdown function from bootstrap to install.php and rewrite the commit message
  10. Philipp Gampe voted on patch set 4 V +1 CR +1 10/12/13, 10:13

  11. Oliver Klee commented on patch set 4 10/12/13, 10:30

    Install.php:115

    I propose to change this to a guard clause with an early return. This will reduce the indentation level of the big code block by one leve.

    Install.php:118

    Maybe here as well.
  12. Mr. Jenkins commented on patch set 3 10/12/13, 10:35

  13. Mr. Jenkins commented on patch set 4 10/12/13, 10:46

  14. Nicole Hummel commented on patch set 4 10/12/13, 17:52

    Install.php:115 Reply

    I don't get why we should send any return as this is a shutdown function?!
  15. Oliver Klee commented on patch set 4 10/16/13, 11:17

    I'll update the changeset with the guard clauses in a second.

    Install.php:115 Reply

    With "early return", I did not mean "return value", but something like this: if ($error === NULL) { return; }
  16. Nicole Hummel commented on patch set 4 10/16/13, 11:18

    Not sure if we still need that patch?! Christian?
  17. Oliver Klee uploaded patch set 6 10/16/13, 11:28

  18. Oliver Klee commented on patch set 6 10/16/13, 11:29

    I've updated the patch to use two guard clauses in order to avoid this deep indentation. I have not tested this patch, though.
  19. Mr. Jenkins commented on patch set 6 10/16/13, 11:42

  20. Christian Kuhn voted on patch set 6 CR 0 10/16/13, 19:20

  21. Wouter Wolters commented on patch set 6 10/16/13, 19:24

    Install.php:161

    totally broke

    Install.php:162

    extListArray is wrong now.

    Install.php:163

    Install Tool

    Install.php:164

    any -> a
  22. Oliver Klee uploaded patch set 7 10/22/13, 16:39

  23. Mr. Jenkins commented on patch set 7 10/22/13, 16:49

  24. Nicole Hummel abandoned the change 03/21/14, 19:51

    Superfluous with failsafe package manager