24549[FEATURE] Introduce MultipleReferenceProxies
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- typo3/sysext/extbase/Classes/Domain/Model/Category.php1+37 −0
- typo3/sysext/extbase/Classes/Domain/Model/Content.php1new+37 −0
- typo3/sysext/extbase/Classes/Domain/Model/Page.php1new+37 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+29 −14
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php1+53 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php1+62 −24
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+16 −11
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+12 −1
- typo3/sysext/extbase/Classes/Persistence/MultipleReferenceProxy.php1new+126 −0
- typo3/sysext/extbase/Classes/Persistence/MultipleReferenceProxyInterface.phpnew+49 −0
- typo3/sysext/extbase/ext_typoscript_setup.txt1+8 −0
Review log 19
-
Mr. Jenkins commented on patch set 1 10/11/13, 06:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11232/ : SUCCESS -
Alexander Schnitzler uploaded patch set 2 10/11/13, 11:43
-
Mr. Jenkins commented on patch set 2 10/11/13, 12:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11252/ : SUCCESS -
Alexander Schnitzler uploaded patch set 3 10/11/13, 16:58
-
Alexander Schnitzler rebased onto patch set 3 10/11/13, 16:58
-
Alexander Schnitzler commented on patch set 4 10/11/13, 17:08
Alright, this still is WIP, but it's almost finished. I also put this commit on github and let travis have a look at it. Here's the build: https://travis-ci.org/alexanderschnitzler/TYPO3-Sandbox/builds/12427986 -
Mr. Jenkins commented on patch set 3 10/11/13, 19:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11286/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/11/13, 19:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11287/ : SUCCESS -
Anja Leichsenring uploaded patch set 5 10/13/13, 10:04
-
Anja Leichsenring uploaded patch set 6 10/13/13, 10:26
-
Mr. Jenkins commented on patch set 5 CR -1 V -1 10/13/13, 10:45
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/11416/ : FAILURE -
Anja Leichsenring uploaded patch set 7 10/13/13, 11:26
-
Anja Leichsenring commented on patch set 7 CR -1 10/13/13, 11:26
Intermediate push, tests fail -
Mr. Jenkins commented on patch set 6 CR -1 V -1 10/13/13, 11:44
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/11421/ : FAILURE -
Anja Leichsenring commented on patch set 7 CR -2 10/13/13, 11:52
This needs more work, Architecture and Use Case are not clear enough. -
Alexander Schnitzler commented on patch set 7 CR -1 10/13/13, 11:55
Category.php:56Shouldn't we remove the @lazy here?Content.php:1Remove this modelPage.php:1Remove this modelDataMapFactory.php:281Remove this lineDataMapper.php:323Typehint not yet namespacedMultipleReferenceProxy.php:108Here we need to catch possible Exceptions and just ignore them. People must configure their proxies right in order to get child elements.ext_typoscript_setup.txt:14Lets replace all these configurations with just one for sys_file as it's the only model we currently have for categorizable system tables. The hint is wrong as you shouldn't edit this file. Better we write an article on how to use the proxies. -
Helmut Hummel commented on patch set 7 CR -1 10/13/13, 12:05
This hides a broken design as feature It mixes concerns of a content repository where you can store flexible content nodes with a relational domain model structure. Extbase ORM was never designed as content repository and thus lacks such capabilities. Introducing hacks to the ORM layer does not make it a CR either but will lead to a conceptual mess bluring the boundries between strong and structured domain models and flexible, hierarchical content nodes. -
Mr. Jenkins commented on patch set 7 CR -1 V -1 10/13/13, 12:54
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/11427/ : FAILURE -
Alexander Schnitzler abandoned the change 01/13/14, 19:11