Review main Abandoned

24549[FEATURE] Introduce MultipleReferenceProxies

Torsten Schrade CR 0 V 0 Hard +466 −52 updated 01/13/14, 19:11

Commit message

Currently Extbase cannot handle references between records of type
"group" and internal type "db" as it connects records of multiple different
types. This already is widely uses by making records categorizable.

This patch introduces a multiple reference proxy, a proxy for a
object storage that manages different types of records. Using this proxy
e.g. the items property of the category model can be resolved correctly,
no matter which types of records the category is connected with.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 19

  1. Mr. Jenkins commented on patch set 1 10/11/13, 06:43

  2. Alexander Schnitzler uploaded patch set 2 10/11/13, 11:43

  3. Mr. Jenkins commented on patch set 2 10/11/13, 12:18

  4. Alexander Schnitzler uploaded patch set 3 10/11/13, 16:58

  5. Alexander Schnitzler rebased onto patch set 3 10/11/13, 16:58

  6. Alexander Schnitzler commented on patch set 4 10/11/13, 17:08

    Alright, this still is WIP, but it's almost finished. I also put this commit on github and let travis have a look at it. Here's the build: https://travis-ci.org/alexanderschnitzler/TYPO3-Sandbox/builds/12427986
  7. Mr. Jenkins commented on patch set 3 10/11/13, 19:04

  8. Mr. Jenkins commented on patch set 4 10/11/13, 19:17

  9. Anja Leichsenring uploaded patch set 5 10/13/13, 10:04

  10. Anja Leichsenring uploaded patch set 6 10/13/13, 10:26

  11. Mr. Jenkins commented on patch set 5 CR -1 V -1 10/13/13, 10:45

  12. Anja Leichsenring uploaded patch set 7 10/13/13, 11:26

  13. Anja Leichsenring commented on patch set 7 CR -1 10/13/13, 11:26

    Intermediate push, tests fail
  14. Mr. Jenkins commented on patch set 6 CR -1 V -1 10/13/13, 11:44

  15. Anja Leichsenring commented on patch set 7 CR -2 10/13/13, 11:52

    This needs more work, Architecture and Use Case are not clear enough.
  16. Alexander Schnitzler commented on patch set 7 CR -1 10/13/13, 11:55

    Category.php:56

    Shouldn't we remove the @lazy here?

    Content.php:1

    Remove this model

    Page.php:1

    Remove this model

    DataMapFactory.php:281

    Remove this line

    DataMapper.php:323

    Typehint not yet namespaced

    MultipleReferenceProxy.php:108

    Here we need to catch possible Exceptions and just ignore them. People must configure their proxies right in order to get child elements.

    ext_typoscript_setup.txt:14

    Lets replace all these configurations with just one for sys_file as it's the only model we currently have for categorizable system tables. The hint is wrong as you shouldn't edit this file. Better we write an article on how to use the proxies.
  17. Helmut Hummel commented on patch set 7 CR -1 10/13/13, 12:05

    This hides a broken design as feature It mixes concerns of a content repository where you can store flexible content nodes with a relational domain model structure. Extbase ORM was never designed as content repository and thus lacks such capabilities. Introducing hacks to the ORM layer does not make it a CR either but will lead to a conceptual mess bluring the boundries between strong and structured domain models and flexible, hierarchical content nodes.
  18. Mr. Jenkins commented on patch set 7 CR -1 V -1 10/13/13, 12:54

  19. Alexander Schnitzler abandoned the change 01/13/14, 19:11