Review main Abandoned

24597[FEATURE] Page module: Allow paste copied tt_content elements

Jose Antonio Guerra CR 0 V 0 Normal +91 −6 updated 03/19/14, 23:34

Commit message

Allows to paste tt_elements from the clipboard after existing content
elements or on the top of the column colPos=0.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 28

Show 3 earlier messages
  1. Xavier Perseguers uploaded patch set 2 10/11/13, 18:19

  2. Mr. Jenkins commented on patch set 1 CR -1 V -1 10/11/13, 18:52

  3. Mr. Jenkins commented on patch set 2 CR -1 V -1 10/11/13, 20:44

  1. Xavier Perseguers uploaded patch set 3 10/11/13, 21:03

  2. Mr. Jenkins commented on patch set 3 CR -1 V -1 10/11/13, 21:55

  3. Jose Antonio Guerra uploaded patch set 4 10/12/13, 22:58

  4. Mr. Jenkins commented on patch set 4 10/13/13, 00:58

  5. Ernesto Baschny commented on patch set 4 V -1 10/13/13, 08:35

    Thanks for the patch. What I find a bit unfinished: * the icons should not be always displayed but together with the "create element" only on mouse over a certain column * why is the "colPos=0" treated differently than other columns? It should work equally on all columns * After Copying an element, the page is not "reloaded" so the icon only appears after a reload of the frame. This is counter-intuitive. Either reload when clicking "Copy" in the Context menu (easier), or add the "Paste" icons dynamically to the page module after they have been copied (more difficult, I guess). * There is no way to "clean" or "show" the clipboard in the Page View, so once you copy something, you cannot get rid of these paste icons ever again: Except in the "List" view. Considering these conceptual thoughts, I guess this usability enhancements needs more polishing and finishing. Thanks for your work on it so far!
  6. Stefan Neufeind commented on patch set 4 10/13/13, 11:25

    I usually click on an element and from the context-menu select "insert after". While this is not optimal, it at least works. What is still broken though is the case when a new column doesn't yet contain elements - you can't paste then. And this is one thing the patch would solve.
  7. Jose Antonio Guerra commented on patch set 4 10/14/13, 08:22

    I'm aware that the patch could be more complete but I aimed to get as much enhancement as possible without complicating it too much. I agree on the refresh and the little details pointed out but there's IMO two issues that may require a bigger deal to complete: * The colPos=0 restriction is due to the fact that there's no direct way to force the value on pasting a tt_content element into a page. If you "paste after" an existing tt_content element that value is forced but not in you paste into an empty column (that's pasting into "pages" table...). Probably to handle this correctly I'd have to patch several other classes on the core and will increment an order of magnitude on the overall complexity. * To show the clipboard on the page module is a nice idea but again it may make the patch much complex. I would better handle those two features on separate issues so they could be managed independently. I would prefer to have 90% of the functionality as soon as possible (to hopefully make it into 6.2) and then work on the remaining 10%. Anyway I'll try to work out the code for this on the week. Thanks for the reviews!
  8. Stefan Neufeind commented on patch set 4 CR +1 10/14/13, 09:01

    @Ernesto: Could you maybe rethink your vote, in the light of the feature-freeze? I agree with your comments though. The "create"-icon thing is of course right. Maybe that is easily fixable now and soon after. The colPos-thing is not shortly fixable easily. I also looked into that yesterday. But maybe we can add some general functionality to set certain values/fields via url that will allow to pass colPos or whatever else as a general solution for all the tables - but that is clearly to be improved later imho. I'd personally be fine if we add followup-issues for the things you pointed out, and Jose agreed to look into them shortly.
  9. Stefan Neufeind commented on patch set 4 10/14/13, 09:01

    PageLayoutView.php:1974

    whitespaces
  10. Jose Antonio Guerra uploaded patch set 5 10/15/13, 10:38

  11. Jose Antonio Guerra commented on patch set 5 10/15/13, 10:45

    On the proposed changes: * The icons should not be always displayed but together with the "create element" only on mouse over a certain column Done * After Copying an element, the page is not "reloaded" so the icon only appears after a reload of the frame. Done, but this was actually pretty complex to complete properly. * There is no way to "clean" or "show" the clipboard in the Page View, so once you copy something, you cannot get rid of these paste icons ever again: Except in the "List" view. As Stefan proposed, may we just create a new task to follow up this feature for the future?
  12. Jose Antonio Guerra commented on patch set 5 10/15/13, 10:57

    I've found a reported issue that is also fixed by this patch: http://forge.typo3.org/issues/31507#note-2
  13. Mr. Jenkins commented on patch set 5 10/15/13, 13:16

  14. Stefan Neufeind uploaded patch set 6 10/17/13, 08:49

  15. Stefan Neufeind commented on patch set 6 10/17/13, 08:50

    rebased
  16. Stefan Neufeind commented on patch set 6 V +1 CR +1 10/17/13, 08:54

    The basics work for me. Although we might need to have some polishing, I think it would be good to have this in. One nitpick is that for an empty page the insert-icon on colPos=0 is always shown, while on the other pages it just shows on hover. But I think we can take care of that for example when pasting to a different column than colPos=0 is added or so.
  17. Mr. Jenkins commented on patch set 6 10/17/13, 09:04

  18. Stefan Neufeind commented on patch set 6 11/11/13, 17:47

    @Ernesto: Still 6.2 or not? I personally feel it would help to have the pasting work a bit better. Or maybe consider this as kind of a "bugfix" (for broken paste-behaviour) for 6.2 even?
  19. Stefan Neufeind commented on patch set 6 V 0 CR -1 11/24/13, 20:11

    Since https://review.typo3.org/25532 is merged now, I guess this one here is obsolete? Could you please test the patch which landed in master?
  20. Stefan Neufeind commented on patch set 6 11/24/13, 20:15

    Hmm, might make sense to propose this as an addition for the now merged functionality as "paste above/below existing content-elements"? If that needs to be handled as a "feature" I'm a bit undecided then. We already have icons to add a content-element before/between/after existing elements. So maybe adding an insert-icon there would now be not that much work anymore?
  21. Stefan Neufeind commented on patch set 6 01/30/14, 16:04

    Ernesto, you wanted to please have a look at how to proceed here and let us know.
  22. Bernhard Kraft commented on patch set 6 03/18/14, 14:09

    Is this still an issue? Jose: Can you verify that this feature got properly implemented by patch: https://review.typo3.org/#/c/25532/ And that the following: http://forge.typo3.org/issues/31507#note-2 is also resolved now?
  23. Jose Antonio Guerra commented on patch set 6 03/18/14, 16:43

    > Jose: Can you verify that this feature got properly implemented by patch: https://review.typo3.org/#/c/25532/ It is, and also allows to paste on columns other than colPos=0 so.. much better! :) > And that the following: http://forge.typo3.org/issues/31507#note-2 is also resolved now? It is indeed
  24. Stefan Neufeind abandoned the change 03/18/14, 16:59

    implemented by other patch
  25. Bernhard Kraft commented on patch set 6 03/19/14, 23:34

    Additionally it would be possible for the grid-elements extension to drop its hooks for TCEmain handling of copy/paste. At least the code for pasting elements into a special column - the hook code for handling recursion (nested elements) will still be required.