24598[FEATURE] Introduce a PHP Enumeration type
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Sebastian Fischer +1
-
Verified V +2
- Christian Kuhn +2
- Sebastian Fischer +1
Issues 1
Files 1
Review log 20
-
Sascha Egerer commented on patch set 1 10/11/13, 17:09
Do we have to rename this to EnumAbstract because it is an abstract class? -
Wouter Wolters commented on patch set 1 CR -1 10/11/13, 17:10
quick code reviewEnum.php:82space after foreachEnum.php:95space after ifEnum.php:115type?Enum.php:130boolean -
Sascha Egerer commented on patch set 1 10/11/13, 17:16
Enum.php:82ReplyDoneEnum.php:95ReplyDoneEnum.php:115ReplyDoneEnum.php:130ReplyDone -
Sascha Egerer uploaded patch set 2 10/11/13, 17:19
-
Wouter Wolters voted on patch set 2 CR +1 10/11/13, 17:19
-
Markus Klein commented on patch set 2 CR -1 10/11/13, 17:33
AbststractEnum.php:52Exception Code missingAbststractEnum.php:59here tooAbststractEnum.php:70invert condition and return early.AbststractEnum.php:77code missingAbststractEnum.php:121return in_array($value, static::$enumConstants[get_called_class()]);AbststractEnum.php:132better name please: e.g. getConstantsListAbststractEnum.php:144CGL, no space after cast -
Sascha Egerer commented on patch set 2 10/11/13, 17:41
AbststractEnum.php:52ReplyDoneAbststractEnum.php:59ReplyDoneAbststractEnum.php:70ReplyDoneAbststractEnum.php:77ReplyDoneAbststractEnum.php:121ReplyDoneAbststractEnum.php:132ReplyI think we should keep that because this is the name from the original SplEnum http://php.net/manual/en/class.splenum.phpAbststractEnum.php:144ReplyDone -
Sascha Egerer uploaded patch set 3 10/11/13, 17:42
-
Xavier Perseguers voted on patch set 3 CR +1 10/11/13, 18:15
-
Markus Klein voted on patch set 3 CR +1 10/11/13, 18:24
-
Mr. Jenkins commented on patch set 1 10/11/13, 19:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11289/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/11/13, 19:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11290/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/11/13, 20:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11291/ : SUCCESS -
Sascha Egerer uploaded patch set 4 10/12/13, 10:33
-
Mr. Jenkins commented on patch set 4 10/12/13, 11:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11319/ : SUCCESS -
Xavier Perseguers commented on patch set 4 10/12/13, 14:17
Enumeration.php:145I thought you wanted to have the same interface than the Spl class? -
Sascha Egerer commented on patch set 4 10/12/13, 14:46
Enumeration.php:145ReplyWe have discussed this again and decided to rename it. We have also removed the info that it emulates the SplEnum because it dousn't. -
Sebastian Fischer voted on patch set 4 V +1 CR +1 10/12/13, 14:48
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/12/13, 15:07
-
Christian Kuhn merged patch set 5 10/12/13, 15:07