24633[FEATURE] Create an UnlessViewHelper as opposite to the IfViewHelper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 11
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 10/12/13, 15:28
-
Helmut Hummel commented on patch set 1 10/12/13, 16:15
What about adding the compiling stuff from the if view helper? or extend abstract condition viewhelper and reuse the compiling from there? -
Helmut Hummel commented on patch set 1 10/12/13, 16:18
Disclaimer: I have no idea how that could work, if it works at all -
Helmut Hummel commented on patch set 1 10/12/13, 16:22
UnlessViewHelper.php:57How would the inline notation look like? -
Mr. Jenkins commented on patch set 1 10/12/13, 17:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11353/ : SUCCESS -
Anja Leichsenring commented on patch set 1 CR -1 10/12/13, 18:15
I will rethink this. To have a shorthand syntax will be very handy! -
Wouter Wolters wrote 10/16/13, 18:11
Topic set to "fluid". -
Anja Leichsenring commented on patch set 1 10/27/13, 11:09
I am all in for using the if-VH, reversing the condition and be done. This are five lines of code we reuse, I think this is bearable in comparison to the gains: - shorthand syntax - then and else possible consider this use case: <f:for each="{entries} as="entry" iteration="foo"> <li class="{f:unless (condition:foo.isLast, then: 'list_entry', else:'list_entry_last)}"></li> </f:for> -
Helmut Hummel commented on patch set 1 10/27/13, 16:40
+1 for this approach -
Aske Ertmann commented on patch set 1 02/15/14, 12:16
Hi. Just FYI this discussion is going on in I933f48ae63f81e0119d74afb875463a24067cbd7 as well. If you have any insights please share them :) -
Wouter Wolters abandoned the change 07/29/14, 23:16