2465[FEATURE] Link to Install Tool in User Settings
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 6
-
Steffen Gebert commented on patch set 1 06/01/11, 08:46
Hi Ingo, thank you for your contribution! IMHO the whole process of creating the INSTALL_TOOL_ENABLE file in the User Settings (why in the User Settings??) is pretty awkward. I've just created a patch, which automatically creates the file, when the Install Tool is opened as module from the backend. http://git.typo3.org/TYPO3v4/Core.git?a=commit;h=1358b72f48ba9b0f7085e8e9a078c298ee028e24 You can get it from git by checking out the branch sandbox/stephenking/installtool-autocreate (or by doing git fetch --all git cherry-pick 1358b72f48b Are you fine with this? Afterwards I would remove the button from the User Settings. This change builds upon the Install Tool refactoring, that's why I wait with the final push to the review process. Looking forward to your feedback! Steffen -
Steffen Gebert commented on patch set 1 06/01/11, 08:46
Hi Ingo, > Why do we in 2011 still rely on this file-based ENABLE_INSTALL_TOOL? It was not invented SO long ago (few years ago you had to change the file typo3/install/index.php). I think the solution is pretty safe and good. > Don't show the default password - or just generate a password as Wordpress or Drupal (don't remember exactly which of those did ;)) The Introduction Package allows to creates a password (which is used for the admin account and the Install Tool). > I would suggest not to use joh316 anymore, but I am not aware of the politics behind that. Yes, I would say it's purely politics to keep this as default password for the blankpackage. > If you want to delete the ENABLE_INSTALL_TOOL file you still have to do it in the User Admin Tab. Maybe there is a more sophisticated way to do this (e.g. sth. like "Log out from Install Tool" that removes the file. I also thought of this scenario. When you really log out from the Install Tool (there's a button in the menu), then the ENABLE_INSTALL_TOOL file is also removed and it is secured. However, it gets recreated, when you open the module, but do not login. We *might* add a button to delete that file (without having to enter the password), but IMHO it's a bit overkill. > So I will abandon this Change and close the issue, ok? Fine! I will wait a few weeks, for the Install Tool refactoring being integrated (as I rely on the BasicService file). Otherwise I will add it with my change. -
Ingo Pfennigstorf commented on patch set 1 06/01/11, 08:46
Hi Steffen, thanks for your really kind feedback! Just checked out your branch. Your changes make a lot of sense. Works perfectly in my test environment. But ... Just two or three things that came to my mind: * Why do we in 2011 still rely on this file-based ENABLE_INSTALL_TOOL? Maybe there are better solutions for protecting the Install Tool (unfortunatly I don't have one) * Don't show the default password - or just generate a password as Wordpress or Drupal (don't remember exactly which of those did ;)) I would suggest not to use joh316 anymore, but I am not aware of the politics behind that. * If you want to delete the ENABLE_INSTALL_TOOL file you still have to do it in the User Admin Tab. Maybe there is a more sophisticated way to do this (e.g. sth. like "Log out from Install Tool" that removes the file. But I'm glad you did that change. It was always kind of awkward and a lack of usability not having a good workflow for accessing the Install Tool. Great work! So I will abandon this Change and close the issue, ok? -
Ingo Pfennigstorf commented on patch set 1 06/01/11, 08:46
Abandoned There will be a more sophisticated solution by Steffen Gebert making this change obsolete. -
Mr. Jenkins commented on patch set 1 06/01/11, 08:46
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/585/ : SUCCESS -
Ingo Pfennigstorf commented on patch set 1 06/01/11, 08:46
Sorry, Steffen, I did not find the proper way to close my Issue on http://forge.typo3.org/issues/27171 ... Maybe this is just possible by CoreDevs?