Review main Merged

24671[FEATURE] Add filter for available records in multi select element

Marc Bastian Heinrichs CR +2 V +2 Normal +158 −2 updated 10/14/13, 09:58

Commit message

This patch adds the possibility to filter available items in a multi
select element. By TCA settings you could enable a text field for
individual word filter and you could predefine search words the user
can select in a drop down.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Alexander Opitz +1
  • Verified V +2
    • Anja Leichsenring +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 10/13/13, 10:19

  2. Anja Leichsenring uploaded patch set 2 10/13/13, 12:12

  3. Anja Leichsenring commented on patch set 2 V +1 CR +1 10/13/13, 12:14

    nice one, thanks a lot. Integrators will love the Feature.
  4. Alexander Opitz voted on patch set 2 V +1 CR +1 10/13/13, 12:49

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/13/13, 12:49

  6. Anja Leichsenring merged patch set 3 10/13/13, 12:49

  7. Wouter Wolters commented on patch set 3 10/13/13, 13:13

    See comments

    FormEngine.php:563

    integer

    FormEngine.php:2317

    space after foreach
  8. Mr. Jenkins commented on patch set 2 10/13/13, 14:08

  9. Frans Saris commented on patch set 3 10/13/13, 17:13

    Is there already a documentation issue for this feature?
  10. Christian Kuhn commented on patch set 3 10/13/13, 18:19

    documentation issue: http://forge.typo3.org/issues/52760 for a ticket without that much information currently, maybe author / reviewers could come up with a documentation proposal?
  11. Marc Bastian Heinrichs commented on patch set 3 10/14/13, 09:15

    thx for creation the doc issue, had this also on my list.
  12. Marc Bastian Heinrichs commented on patch set 3 10/14/13, 09:58

    Thx Wouter, here is the follow-up https://review.typo3.org/#/c/24727/