Review main Merged

24721[BUGFIX] Detect unix-styled absolute paths on Windows systems

Nicole Hummel CR +2 V +2 Easy +2 −2 updated 10/14/13, 09:39

Commit message

Currently PathUtility::isAbsolutePath and GeneralUtility::isAbsPath
only the for ":\" to detect absolute paths on Windows systems. This
patch provides even ":/" as unix-styled paths are mostly used now.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Thomas Maroschik +1
    • Sascha Egerer +1
    • Wouter Wolters +1
    • Xavier Perseguers +1
    • Jigal van Hemert +1
  • Verified V +2
    • Nicole Hummel +2
    • Xavier Perseguers +1
    • Jigal van Hemert +1

Issues 1

Files 2

Review log 12

  1. Nicole Hummel uploaded patch set 2 10/14/13, 08:15

  2. Thomas Maroschik voted on patch set 2 CR +1 10/14/13, 08:21

  3. Wouter Wolters voted on patch set 2 CR +1 10/14/13, 08:23

  4. Sascha Egerer voted on patch set 2 CR +1 10/14/13, 08:26

  5. Mr. Jenkins commented on patch set 1 10/14/13, 08:44

  6. Thomas Maroschik wrote 10/14/13, 08:54

    Topic set to "packagemanager-in-cms".
  7. Xavier Perseguers voted on patch set 2 V +1 CR +1 10/14/13, 08:55

  8. Mr. Jenkins commented on patch set 2 10/14/13, 08:58

  9. Jigal van Hemert commented on patch set 2 V +1 CR +1 10/14/13, 09:22

    Verb missing...
  10. Nicole Hummel voted on patch set 2 V +2 CR +2 10/14/13, 09:38

  11. Nicole Hummel merged patch set 3 10/14/13, 09:38

  12. Nicole Hummel commented on patch set 3 10/14/13, 09:39

    Cherry Picked This patchset was cherry picked to change: I1e132bbe74394861af4bf02a22287c9496953150