Review main Merged

24723[BUGFIX] Use callback in preg_replace in RemoveXSS

Jigal van Hemert CR +2 V +2 Normal +38 −26 updated 10/14/13, 22:36

Commit message

Since PHP 5.5.0 the use of the /e modifier is deprecated in preg_replace.
Use callback function instead.
Also change comments to CGL format.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Files 1

Review log 9

  1. Wouter Wolters voted on patch set 1 CR +1 10/14/13, 08:37

  2. Mr. Jenkins commented on patch set 1 10/14/13, 09:23

  3. Xavier Perseguers commented on patch set 1 CR +1 10/14/13, 09:27

    Looks quite straightforward
  4. Stefan Neufeind uploaded patch set 2 10/14/13, 21:50

  5. Stefan Neufeind commented on patch set 2 V +1 CR +1 10/14/13, 21:53

    Guys, the e-modifier itself of course must be *removed* after by this change (is now). There were examples given in the sourcecode already, so at least those two lines are easy to test. They work for me. The rest are just comment-changes (aka cosmetics/CGL).
  6. Markus Klein commented on patch set 2 V +2 CR +2 10/14/13, 22:02

    Added the reference to the original PHP 5.5 cleanup in #49300 to forge.
  7. Markus Klein merged patch set 3 10/14/13, 22:02

  8. Markus Klein commented on patch set 3 10/14/13, 22:03

    Cherry Picked This patchset was cherry picked to change: I44f12e8bfa1c976e494dae847cc6c53d15ed7c2d
  9. Mr. Jenkins commented on patch set 2 10/14/13, 22:36