Review main Merged

24726[BUGFIX] Adapt IndexerService to new table structures

Steffen Ritter CR +2 V +2 Normal +92 −37 updated 10/14/13, 13:31

Commit message

When introducing sys_file_metadata and rearranging FAL
to do so some parts of the IndexerService have been
forgotten.
The IndexerService is now adapted to not do SQL itself
anymore and to push the imagesizes to the metadata table.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Xavier Perseguers +1
  • Verified V +2
    • Steffen Ritter +2
    • Xavier Perseguers +1

Issues 1

Files 6

Review log 13

  1. Xavier Perseguers commented on patch set 1 V -1 10/14/13, 10:05

    When uploading an image, I get 1: Uploaded file could not be moved! Write-permission problem in "/"? but the actual (inner) exception is Metadata can only be retrieved for indexed files. thrown from line 156 of \TYPO3\CMS\Core\Resource\Service\IndexerService::indexFile: $this->getMetaDataRepository()->update($fileInfo['uid'], $metaData);
  2. Steffen Ritter uploaded patch set 2 10/14/13, 10:16

  3. Mr. Jenkins commented on patch set 1 10/14/13, 10:22

  4. Steffen Ritter uploaded patch set 3 10/14/13, 10:42

  5. Steffen Ritter commented on patch set 3 10/14/13, 10:42

    sry, patch set 2 contained a unrelated file
  6. Xavier Perseguers voted on patch set 3 V +1 CR +1 10/14/13, 11:02

  7. Mr. Jenkins commented on patch set 2 CR -1 V -1 10/14/13, 11:36

  8. Steffen Ritter uploaded patch set 4 10/14/13, 11:44

  9. Xavier Perseguers voted on patch set 4 V +1 CR +1 10/14/13, 11:54

  10. Mr. Jenkins commented on patch set 3 10/14/13, 12:23

  11. Mr. Jenkins commented on patch set 4 10/14/13, 13:28

  12. Steffen Ritter commented on patch set 4 V +2 CR +2 10/14/13, 13:31

    Merged as a follow-up to the split-tables patch
  13. Steffen Ritter merged patch set 5 10/14/13, 13:31