Review main Merged

24731[FEATURE] Show extension keys in documentation list

Nicole Hummel CR +2 V +2 Easy +43 −0 updated 10/15/13, 08:56

Commit message

Show extension keys in the lists as well.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Xavier Perseguers +1
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Xavier Perseguers +1
    • Nicole Hummel +1

Issues 1

Files 6

Review log 10

  1. Mr. Jenkins commented on patch set 1 10/14/13, 12:35

  2. Wouter Wolters commented on patch set 1 10/14/13, 16:58

    For core extensions in the Show list there is no extensionKey, attached a screen to forge. Rest looks fine to me.
  3. Sebastian Fischer voted on patch set 1 CR +1 10/14/13, 19:13

  4. Xavier Perseguers commented on patch set 1 10/15/13, 06:42

    @Wouter, the empty columns are certainly due to EXT:sphinx which should be adapted as well
  5. Xavier Perseguers uploaded patch set 2 10/15/13, 06:53

  6. Xavier Perseguers commented on patch set 2 V +1 CR +1 10/15/13, 06:57

    Wouter was right, we had missing extension key for extension only providing a Sphinx/reStructuredText-based manual (no OpenOffice) even without using EXT:sphinx. Related fix for EXT:sphinx: https://review.typo3.org/24777
  7. Mr. Jenkins commented on patch set 2 10/15/13, 07:48

  8. Nicole Hummel commented on patch set 2 V +1 CR +1 10/15/13, 08:47

    As I haven't installed sphinx I havn't any issue with that. But looks (still) good to me
  9. Wouter Wolters voted on patch set 2 V +2 CR +2 10/15/13, 08:56

  10. Wouter Wolters merged patch set 3 10/15/13, 08:56