24731[FEATURE] Show extension keys in documentation list
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Xavier Perseguers +1
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Xavier Perseguers +1
- Nicole Hummel +1
Issues 1
Files 6
- typo3/sysext/documentation/Classes/Domain/Model/Document.php+28 −0
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php+4 −0
- typo3/sysext/documentation/Classes/Service/DocumentationService.php+1 −0
- typo3/sysext/documentation/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/documentation/Resources/Private/Templates/Document/List.html+2 −0
- typo3/sysext/documentation/Resources/Private/Templates/Document/Manage.html+2 −0
Review log 10
-
Mr. Jenkins commented on patch set 1 10/14/13, 12:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11482/ : SUCCESS -
Wouter Wolters commented on patch set 1 10/14/13, 16:58
For core extensions in the Show list there is no extensionKey, attached a screen to forge. Rest looks fine to me. -
Sebastian Fischer voted on patch set 1 CR +1 10/14/13, 19:13
-
Xavier Perseguers commented on patch set 1 10/15/13, 06:42
@Wouter, the empty columns are certainly due to EXT:sphinx which should be adapted as well -
Xavier Perseguers uploaded patch set 2 10/15/13, 06:53
-
Xavier Perseguers commented on patch set 2 V +1 CR +1 10/15/13, 06:57
Wouter was right, we had missing extension key for extension only providing a Sphinx/reStructuredText-based manual (no OpenOffice) even without using EXT:sphinx. Related fix for EXT:sphinx: https://review.typo3.org/24777 -
Mr. Jenkins commented on patch set 2 10/15/13, 07:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11552/ : SUCCESS -
Nicole Hummel commented on patch set 2 V +1 CR +1 10/15/13, 08:47
As I haven't installed sphinx I havn't any issue with that. But looks (still) good to me -
Wouter Wolters voted on patch set 2 V +2 CR +2 10/15/13, 08:56
-
Wouter Wolters merged patch set 3 10/15/13, 08:56