Review main Abandoned

24776[TASK] Replace new() by makeInstance() in Validation section

Georg Ringer CR 0 V 0 Easy +15 −10 updated 10/16/13, 07:53

Commit message

The core should use GeneralUtility::makeInstance() instead of new
<Classname>.

This is fixed now for the validation section of extbase.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 7

  1. Mr. Jenkins commented on patch set 1 10/15/13, 04:09

  2. Kay Strobach voted on patch set 1 V +1 CR +1 10/15/13, 06:44

  3. Sebastian Fischer voted on patch set 1 CR +1 10/15/13, 08:17

  4. Christian Kuhn updated the commit message in patch set 1 10/15/13, 08:22

  5. Stefan Neufeind voted on patch set 2 CR +1 10/15/13, 09:59

  6. Helmut Hummel commented on patch set 2 10/15/13, 10:38

    What is the point here? Just for the sake of consistence? Or to support XCLASS? I would rather like to keep it simple here.
  7. Georg Ringer abandoned the change 10/16/13, 07:53

    not needed