2479[BUGFIX] Scheduler: Task object state is not saved after execution
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/scheduler/examples/class.tx_scheduler_savetaskobjectstatetask.phpnew+72 −0
- typo3/sysext/scheduler/mod1/locallang.xml+1 −0
- typo3/sysext/scheduler/class.tx_scheduler.php+38 −14
- typo3/sysext/scheduler/class.tx_scheduler_task.php+39 −0
- typo3/sysext/scheduler/ext_autoload.php+1 −0
- typo3/sysext/scheduler/ext_localconf.php+7 −0
- typo3/sysext/scheduler/locallang.xml+2 −0
Review log 4
-
Francois Suter commented on patch set 1 07/04/11, 14:50
I would prefer that you didn't submit this I'm unconvinced by the solution. Furthermore I don't think it's such a good idea to provide a sample task for this. Better improve the manual. I'll take a look into this. -
Francois Suter commented on patch set 1 07/04/11, 14:50
Do not submit See my note in the Forge issue. The solution is simply to call $this->save() within your task if needed. Andy can you please abandon this change? Only the person who pushed a patch can do so. Thanks. -
Mr. Jenkins commented on patch set 1 07/04/11, 14:50
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/588/ : SUCCESS -
Andy Grunwald commented on patch set 1 07/04/11, 14:50
Abandoned Abandon this patch, because Francois comment is correct and is a nice solution. For more information, please have a look at the forge ticket