Review main Abandoned

2479[BUGFIX] Scheduler: Task object state is not saved after execution

Andy Grunwald CR 0 V 0 Normal +160 −14 updated 06/03/13, 20:49

Commit message

Every scheduler task object is saved as serialized object in the database.
If a schedular task run and modify internal member variables this modifications
are not saved in the database. On the next execution, all internal member variables
are back on default values.

This patch enables the possibility to enable the saving of the task object state
after the execution. Furthermore a new example task
"tx_scheduler_SaveTaskObjectStateTask" was added to show the new functionality.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 4

  1. Francois Suter commented on patch set 1 07/04/11, 14:50

    I would prefer that you didn't submit this I'm unconvinced by the solution. Furthermore I don't think it's such a good idea to provide a sample task for this. Better improve the manual. I'll take a look into this.
  2. Francois Suter commented on patch set 1 07/04/11, 14:50

    Do not submit See my note in the Forge issue. The solution is simply to call $this->save() within your task if needed. Andy can you please abandon this change? Only the person who pushed a patch can do so. Thanks.
  3. Mr. Jenkins commented on patch set 1 07/04/11, 14:50

  4. Andy Grunwald commented on patch set 1 07/04/11, 14:50

    Abandoned Abandon this patch, because Francois comment is correct and is a nice solution. For more information, please have a look at the forge ticket