Review main Merged

24808[BUGFIX] Fix FilePermissionUpdate SQL errors

Nicole Hummel CR +2 V +2 Easy +17 −11 updated 10/15/13, 21:54

Commit message

If you have a new installation or already used the database analyser to
delete unnecessary fields the filePermissionUpdate throws SQL errors
because the old fields aren't available anymore.

Review

  • Code review CR +2
    • Markus Klein +2
    • Ernesto Baschny +1
  • Verified V +2
    • Markus Klein +2
    • Ernesto Baschny +1

Issues 1

Files 1

Review log 10

  1. Markus Klein updated the commit message in patch set 1 10/15/13, 15:11

  2. Ernesto Baschny voted on patch set 2 V +1 CR +1 10/15/13, 15:22

  3. Markus Klein voted on patch set 2 CR +1 10/15/13, 15:26

  4. Markus Klein voted on patch set 2 V +2 CR +2 10/15/13, 15:29

  5. Francois Suter commented on patch set 2 10/15/13, 15:32

    Here again: a +2 but no merge. Why?
  6. Ernesto Baschny commented on patch set 2 10/15/13, 17:48

    grrr, yea that should have gone into beta1! I thought it was merged because of the +2, sorry about that.. :(
  7. Ernesto Baschny merged patch set 3 10/15/13, 17:48

  8. Markus Klein commented on patch set 3 10/15/13, 17:54

    WTF?? Why was that not merged? In this case I really intended to merge immediately. (I communicated this also in Skype) I must have hit the wrong button. Sorry for that.
  9. Mr. Jenkins commented on patch set 1 10/15/13, 21:43

  10. Mr. Jenkins commented on patch set 2 10/15/13, 21:54