Review main Merged

24816[TASK] Add unit tests for FilesContentObject

Nicole Hummel CR +2 V +2 Hard +955 −29 updated 10/17/13, 19:41

Commit message

This patch adds unit tests and some small bug fixes for
TYPO3\CMS\Frontend\ContentObject\FilesContentObject class.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 10

  1. Wouter Wolters commented on patch set 1 10/15/13, 18:26

    FilesContentObject.php:78

    getFileRepository

    FilesContentObject.php:280

    tabs to a space
  2. Christian Kuhn commented on patch set 1 10/15/13, 21:09

    generally a good idea! thx for working on this, very good job! i'm not satisfied with all details, but will have a deeper look at this the next days.
  3. Mr. Jenkins commented on patch set 1 10/15/13, 23:38

  4. Wouter Wolters wrote 10/16/13, 19:25

    Topic set to "unit-test".
  5. Christian Kuhn commented on patch set 1 10/17/13, 19:21

    FilesContentObject.php:78 Reply

    Done

    FilesContentObjectTest.php:36

    lets call this $sut in the future (it is the system under test, not a fixture).

    FilesContentObjectTest.php:213

    Usually, loops in unit tests are not preferred at all. In this special case I think it is ok.
  6. Christian Kuhn uploaded patch set 2 10/17/13, 19:28

  7. Christian Kuhn commented on patch set 2 V +1 CR +1 10/17/13, 19:28

    Good job!
  8. Mr. Jenkins commented on patch set 2 10/17/13, 19:40

  9. Wouter Wolters voted on patch set 2 V +2 CR +2 10/17/13, 19:41

  10. Wouter Wolters merged patch set 3 10/17/13, 19:41