24816[TASK] Add unit tests for FilesContentObject
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 10
-
Wouter Wolters commented on patch set 1 10/15/13, 18:26
FilesContentObject.php:280tabs to a space -
Christian Kuhn commented on patch set 1 10/15/13, 21:09
generally a good idea! thx for working on this, very good job! i'm not satisfied with all details, but will have a deeper look at this the next days. -
Mr. Jenkins commented on patch set 1 10/15/13, 23:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11628/ : SUCCESS -
Wouter Wolters wrote 10/16/13, 19:25
Topic set to "unit-test". -
Christian Kuhn commented on patch set 1 10/17/13, 19:21
FilesContentObject.php:78ReplyDoneFilesContentObjectTest.php:36lets call this $sut in the future (it is the system under test, not a fixture).FilesContentObjectTest.php:213Usually, loops in unit tests are not preferred at all. In this special case I think it is ok. -
Christian Kuhn uploaded patch set 2 10/17/13, 19:28
-
Christian Kuhn commented on patch set 2 V +1 CR +1 10/17/13, 19:28
Good job! -
Mr. Jenkins commented on patch set 2 10/17/13, 19:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11694/ : SUCCESS -
Wouter Wolters voted on patch set 2 V +2 CR +2 10/17/13, 19:41
-
Wouter Wolters merged patch set 3 10/17/13, 19:41
FilesContentObject.php:78