Review main Merged

24837[BUGFIX] Presets cause fatal error during last installation step

Nicole Hummel CR +2 V +2 Easy +8 −15 updated 10/16/13, 19:01

Commit message

This patch restructures the PresetInterface and AbstractPreset usage to
prevent any inheritance which causes a fatal error in some PHP versions.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • Helmut Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Helmut Hummel +1

Issues 1

Files 8

Review log 9

  1. Markus Klein updated the commit message in patch set 1 10/16/13, 11:10

  2. Mr. Jenkins commented on patch set 1 10/16/13, 11:22

  3. Mr. Jenkins commented on patch set 2 10/16/13, 11:25

  4. Markus Klein voted on patch set 2 CR +1 10/16/13, 11:39

  5. Helmut Hummel commented on patch set 2 V +1 CR +1 10/16/13, 13:35

    This is needed for PHP < 5.3.9 http://svn.php.net/viewvc/?view=revision&amp;revision=319548 Since we have 5.3.7 as minimum requirement, we should fix this. It is cleaner this way anyway
  6. Jigal van Hemert commented on patch set 2 V +1 CR +1 10/16/13, 13:36

    Chaining implementation -> abstract -> interface is much clearer. The concept in this patch works in PHP 5.4 (made a few test classes to see if the concept works)
  7. Jigal van Hemert voted on patch set 2 V +2 CR +2 10/16/13, 14:15

  8. Jigal van Hemert merged patch set 3 10/16/13, 14:15

  9. Christian Kuhn commented on patch set 3 10/16/13, 19:01

    post +1. thx!