24837[BUGFIX] Presets cause fatal error during last installation step
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
- Helmut Hummel +1
-
Verified V +2
- Jigal van Hemert +2
- Helmut Hummel +1
Issues 1
Files 8
- typo3/sysext/install/Classes/Configuration/Charset/CoreInternalPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Charset/IconvPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Charset/MbstringPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Context/DevelopmentPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Context/ProductionPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ApcPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/DatabasePreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/AbstractPreset.php+1 −8
Review log 9
-
Markus Klein updated the commit message in patch set 1 10/16/13, 11:10
-
Mr. Jenkins commented on patch set 1 10/16/13, 11:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11644/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/16/13, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11645/ : SUCCESS -
Markus Klein voted on patch set 2 CR +1 10/16/13, 11:39
-
Helmut Hummel commented on patch set 2 V +1 CR +1 10/16/13, 13:35
This is needed for PHP < 5.3.9 http://svn.php.net/viewvc/?view=revision&revision=319548 Since we have 5.3.7 as minimum requirement, we should fix this. It is cleaner this way anyway -
Jigal van Hemert commented on patch set 2 V +1 CR +1 10/16/13, 13:36
Chaining implementation -> abstract -> interface is much clearer. The concept in this patch works in PHP 5.4 (made a few test classes to see if the concept works) -
Jigal van Hemert voted on patch set 2 V +2 CR +2 10/16/13, 14:15
-
Jigal van Hemert merged patch set 3 10/16/13, 14:15
-
Christian Kuhn commented on patch set 3 10/16/13, 19:01
post +1. thx!