Review main Merged

24838[TASK] Unit tests for devIP condition

Christian Kuhn CR +2 V +2 Normal +89 −7 updated 10/16/13, 17:10

Commit message

Cover the condition feature of issue #50092 with some test to
verify expected behaviour.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 2

Files 1

Review log 7

  1. Nicole Hummel commented on patch set 1 10/16/13, 11:36

    AbstractConditionMatcherTest.php:166

    Would it make sense to test 127.0.0.1 and 127.0.0.255 as margin value as well?

    AbstractConditionMatcherTest.php:171

    see above

    AbstractConditionMatcherTest.php:187

    Maybe another test with the right scope but ip higher than allowed?
  2. Mr. Jenkins commented on patch set 1 10/16/13, 11:42

  3. Christian Kuhn commented on patch set 1 10/16/13, 11:44

    AbstractConditionMatcherTest.php:166 Reply

    The tests are not for cmpIP but for the condition matcher. cmpIP and cmpIPv4 and cmpIPv6 have their own more detailed tests that take care of edge cases. In this case i think it is enough if we stick to some simple but systematical cases, thats why i did not implement too many edge cases. For the condition implementation it is more important to ensure that the value is actually read from devIPmask setting and the usual evaluation works.
  4. Nicole Hummel commented on patch set 1 V +1 CR +1 10/16/13, 12:14

    AbstractConditionMatcherTest.php:166 Reply

    Okay, fine with me
  5. Wouter Wolters wrote 10/16/13, 17:02

    Topic set to "unit-test".
  6. Wouter Wolters voted on patch set 1 V +2 CR +2 10/16/13, 17:10

  7. Wouter Wolters merged patch set 2 10/16/13, 17:10