24838[TASK] Unit tests for devIP condition
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Nicole Hummel +1
Issues 2
Files 1
Review log 7
-
Nicole Hummel commented on patch set 1 10/16/13, 11:36
AbstractConditionMatcherTest.php:171see aboveAbstractConditionMatcherTest.php:187Maybe another test with the right scope but ip higher than allowed? -
Mr. Jenkins commented on patch set 1 10/16/13, 11:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11647/ : SUCCESS -
Christian Kuhn commented on patch set 1 10/16/13, 11:44
AbstractConditionMatcherTest.php:166ReplyThe tests are not for cmpIP but for the condition matcher. cmpIP and cmpIPv4 and cmpIPv6 have their own more detailed tests that take care of edge cases. In this case i think it is enough if we stick to some simple but systematical cases, thats why i did not implement too many edge cases. For the condition implementation it is more important to ensure that the value is actually read from devIPmask setting and the usual evaluation works. -
Nicole Hummel commented on patch set 1 V +1 CR +1 10/16/13, 12:14
AbstractConditionMatcherTest.php:166ReplyOkay, fine with me -
Wouter Wolters wrote 10/16/13, 17:02
Topic set to "unit-test". -
Wouter Wolters voted on patch set 1 V +2 CR +2 10/16/13, 17:10
-
Wouter Wolters merged patch set 2 10/16/13, 17:10
AbstractConditionMatcherTest.php:166