Review main Merged

24878[TASK] Exclude central Modernizr from concatenation

Stefan Neufeind CR +2 V +2 Easy +19 −0 updated 10/17/13, 21:28

Commit message

Modernizr is added to every "page" in the backend
as a default in DocumentTemplate. By default all JS
gets merged. Thus Modernizr is added to multiple
files.

Reduce the size of JS-files and allow browsers to
take advantage of reusing that code by having this
library as a separate part.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 10/17/13, 20:44

  2. Markus Klein updated the commit message in patch set 1 10/17/13, 21:14

  3. Markus Klein voted on patch set 2 V +1 CR +1 10/17/13, 21:17

  4. Wouter Wolters voted on patch set 2 V +2 CR +2 10/17/13, 21:18

  5. Wouter Wolters merged patch set 3 10/17/13, 21:18

  6. Wouter Wolters commented on patch set 3 10/17/13, 21:18

    Cherry Picked This patchset was cherry picked to change: If18ca423ac3b4b1347c1319189d0feb019f37b7f
  7. Wouter Wolters commented on patch set 3 10/17/13, 21:18

    Cherry Picked This patchset was cherry picked to change: If18ca423ac3b4b1347c1319189d0feb019f37b7f
  8. Mr. Jenkins commented on patch set 2 10/17/13, 21:28