Review main Merged

24885[BUGFIX] dataTables: Avoid sending cookie-data too often

Stefan Neufeind CR +2 V +2 Easy +34 −6 updated 11/12/13, 21:33

Commit message

All core-modules currently using jQuery-dataTables are
called through mod.php. So by adding that to the
cookie-path we can at least prevent sending those cookies
with requests like JS/CSS/images.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Pascal Dürsteler +1
    • Markus Klein +1
    • Sebastian Fischer +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 4

Review log 7

  1. Stefan Neufeind commented on patch set 1 10/17/13, 23:11

    This does not really "resolve" limiting the cookie-data or only sending it where needed. But by appending mod.php to the URL we can at least restrict sending long cookies for quite a bunch of requests (JS/CSS/images) where it was currently also sent. This should at least save quite some space/bandwidth with requests and prevent at least a bit of speed-loss when working in the backend with some modules. As this doesn't change something about the data stored in the cookies or the like, this should hopefully cause no problems also on older releases - maybe 6.x for now.
  2. Mr. Jenkins commented on patch set 1 10/17/13, 23:21

  3. Sebastian Fischer voted on patch set 1 CR +1 10/30/13, 11:07

  4. Pascal Dürsteler voted on patch set 1 CR +1 10/30/13, 14:11

  5. Markus Klein voted on patch set 1 V +1 CR +1 11/12/13, 16:07

  6. Wouter Wolters voted on patch set 1 V +2 CR +2 11/12/13, 21:33

  7. Wouter Wolters merged patch set 2 11/12/13, 21:33