24902[TASK] Improve calls to the FileRepository
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 16
-
Mr. Jenkins commented on patch set 1 10/19/13, 08:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11724/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 10/19/13, 10:28
-
Alexander Opitz commented on patch set 1 11/08/13, 07:24
FrontendContentAdapterService.php:86IMHO isset can be removed, if we test for empty as $row is no string. 1.) No warning is generated if the variable does not exist. 2.) Only on strings there is a glitch with PHP5.3 => http://www.php.net/manual/en/function.empty.php But I didn't try it with PHP5.3 so it needs to be evaluated. -
Markus Klein uploaded patch set 2 11/22/13, 12:01
-
Markus Klein commented on patch set 1 11/22/13, 12:03
FrontendContentAdapterService.php:86Replycorrect, empty replaces isset. The "glitch" only has todo with string offsets. nothing we use very often in connection with empty. -
Markus Klein updated the commit message in patch set 2 11/22/13, 12:04
-
Markus Klein uploaded patch set 4 11/22/13, 12:05
-
Markus Klein voted on patch set 4 CR +1 11/22/13, 12:06
-
Mr. Jenkins commented on patch set 2 11/22/13, 12:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12269/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/22/13, 12:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12270/ : SUCCESS -
Mr. Jenkins commented on patch set 4 11/22/13, 12:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12271/ : SUCCESS -
Alexander Opitz voted on patch set 4 CR +1 11/22/13, 12:37
-
Steffen Ritter commented on patch set 4 CR -1 11/30/13, 15:28
I'm not sure if we should do that... Currently only tce-main also updates the field count; if you use the mm_opposite_field feature only the initianting site is updated. Therefore we cannot trust the field value... -
Markus Klein voted on patch set 4 CR 0 03/26/14, 21:07
-
Steffen Ritter commented on patch set 4 06/11/14, 12:09
Hi Georg, since nothing happend hier since month, I kindly ask to abandon this change and close the issue in forge. -
Wouter Wolters abandoned the change 01/06/15, 20:02
Georg said we can abandon this one.