24908[TASK] No PHP/TYPO3 version check on -dev versions
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 14
-
Markus Klein uploaded patch set 2 10/20/13, 13:15
-
Mr. Jenkins commented on patch set 1 10/20/13, 13:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11738/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/20/13, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11739/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 10/21/13, 08:58
I do not like this change because: - you still can ignore the version in EM when installing the extension - if you prepare the ext on the dev version for the future release, such warnings help you to remember to update dependencies No -1 though. -
Markus Klein commented on patch set 2 10/21/13, 10:20
"you still can ignore the version in EM when installing the extension" How can I do that? If I click the + symbol to install an extension on master I always get the message, that the version does not match. So if there's an "ignore button", I'm happy to use it and will abandon this patch immediately. -
Alexander Stehlik commented on patch set 2 10/21/13, 13:53
I guess Dmitry is talking about the good ol' times where this was possible ;) One remark after having a look at the code: I think it would be nicer to have a isDevelopmentVersion() method in the VersionNumberUtility. -
Markus Klein commented on patch set 2 10/21/13, 14:11
Yes this would indeed be nicer, but it would be a feature due to new API. -
Alexander Stehlik commented on patch set 2 10/21/13, 14:46
And a new feature is not possible because of the feature freeze? Maybe Ernesto can make an exception in this case because the resulting code would be better and this "feature" is quite simple :) -
Markus Klein commented on patch set 2 10/21/13, 14:55
Actually it would even be better to have the ignore button again in EM. Since the points of Dmitry are very valid. -
Xavier Perseguers commented on patch set 2 10/22/13, 21:32
I would prefer a button to bypass the blocked install. We see many extensions with simply wrong dependencies, even on a released version, for instance with a upper limit to 6.1.4. Once 6.1.5 is out, it cannot be installed anymore and the check for -dev will not help. Having a button to ignore the warning and install anyway would be much more useful than some kind of magic with -dev versions. -
Georg Ringer commented on patch set 2 10/24/13, 09:10
ack to xavier's comment -
Dmitry Dulepov commented on patch set 2 10/30/13, 14:21
I agree with Xavier as well. In fact, several essential things were cut from EM (for example "UPDATE!", which is required for any static_info_tables_XX extension or a way to delete extensions from the server). What this RFC tries to do is to make a workaround for a wrong previous decision. It can be easier to make workarounds but it still does not make the approach right. It is like when you take a painkiller when you actually need a doctor. -
Markus Klein commented on patch set 2 CR -2 11/02/13, 14:22
As already said, I fully agree with you, but I'd like to keep this patch as a reminder for these issues. The code is of course useless now. -
Markus Klein abandoned the change 11/16/13, 17:23
Ok this is being discussed now on the core list intensively, hence this "history" here is useless.