Review main Merged

24923[BUGFIX] Calculations in GIFBUILDER properties using stdWrap fail

Dan Kleine - geb. Untenzu CR +2 V +2 Easy +6 −0 updated 08/15/15, 10:55

Commit message

Unset each existing TypoScript subarray of all properties
with calculations (offset,dimensions,set,…) in GIFBUILDER.
Do this to prevent the double execution of stdWrap,
which would cause those properties to return uncalculated
and therefore wrong values afterwards.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 10/21/13, 13:19

  2. Benni Mack updated the commit message in patch set 2 01/07/15, 17:40

  3. Wouter Wolters commented on patch set 2 01/07/15, 17:45

    is that fixed with #60135?
  4. Dan Kleine - geb. Untenzu commented on patch set 2 01/10/15, 16:23

    Hey guys, #60135 does not fix this one, the bug is still in effect. I added a simpler example to the ticket, because it took me a while to remember what was wrong here as well: https://forge.typo3.org/issues/53002#note-5
  5. Daniel Goerz commented on patch set 2 CR +1 V +1 08/08/15, 16:59

    Before this patch has its 2nd birthday. Lets merge it :)
  6. Philipp Gampe commented on patch set 2 08/08/15, 17:34

    The image is always only white, with and without this patch
  7. Daniel Goerz commented on patch set 2 08/08/15, 17:58

    > The image is always only white, with and without this patch Its working for me. Make sure you have the correct file name and the correct location for the example.
  8. Philipp Gampe commented on patch set 2 CR +1 V +1 08/08/15, 20:35

    arg, had a wrong selinux context on the file ... restorecond will be on my quickfix list for the next time. Just wasted one hour of senseless debugging.
  9. Markus Klein voted on patch set 2 V +2 CR +2 08/15/15, 10:54

  10. Markus Klein merged patch set 2 08/15/15, 10:54

  11. Markus Klein commented on patch set 3 08/15/15, 10:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c615dd7a074c2721fa8562924384c95d0eb5ae84