Review main Merged

24951[BUGFIX] cache_clearAtMidnight conflicts with content start/endtime

Dmitry Dulepov CR +2 V +2 Easy +4 −4 updated 02/11/14, 21:29

Commit message

If the config.cache_ClearAtMidnight is set, the current code of
TypoScriptFrontendController::get_cache_timeout() will not take
content's starttime/endtime into account. Thus if the content
(or other configured record) has start or end time before the
midnight, it will not be taken into account and the cache timeout
will be wrong.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Peter Foerger +1
    • Benni Mack +1
  • Verified V +2
    • Helmut Hummel +2
    • Benni Mack +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 10/22/13, 07:45

  2. Wouter Wolters voted on patch set 1 CR +1 11/02/13, 14:00

  3. Peter Foerger voted on patch set 1 CR +1 11/04/13, 11:41

  4. Benni Mack commented on patch set 1 V +1 CR +1 12/09/13, 06:54

    Very nice patch. Tested all four use cases (clearAtMidnight=1/0 and a content element with/without publish date) with and without the patch. The cache life time now always returns the correct amount of seconds.
  5. Helmut Hummel voted on patch set 1 V +2 CR +2 02/11/14, 21:28

  6. Helmut Hummel merged patch set 2 02/11/14, 21:28

  7. Helmut Hummel commented on patch set 2 02/11/14, 21:29

    Cherry Picked This patchset was cherry picked to change: I732da8f07270a86c62b7ce5028b12b630bb2e027
  8. Helmut Hummel commented on patch set 2 02/11/14, 21:29

    Cherry Picked This patchset was cherry picked to change: I732da8f07270a86c62b7ce5028b12b630bb2e027