Review main Merged

24975[BUGFIX] Show flash message if package states are not writable

Stefan Rotsch CR +2 V +2 Easy +36 −0 updated 11/06/13, 23:12

Commit message

When trying to install/uninstall an extension and PackageStates.php
is not writable, an error flash message is shown.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Steffen Müller +1
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Steffen Müller +1

Issues 1

Files 4

Review log 22

  1. Mr. Jenkins commented on patch set 1 10/23/13, 13:39

  2. Anja Leichsenring commented on patch set 1 V +1 CR +1 10/27/13, 08:50

    good one, thank you!
  3. Dmitry Dulepov commented on patch set 1 10/30/13, 14:13

    PackageManager.php:934

    This message is too cryptic. Nobody except developers will know what is "package states file". Please, use human language instead :) Something like the following will do: "Please check file permissions. File "%s" is not writable."
  4. Steffen Müller uploaded patch set 2 10/30/13, 18:23

  5. Steffen Müller commented on patch set 2 V +1 CR +1 10/30/13, 18:26

    Exception message should be more understandable now. I also changed the commit message.
  6. Mr. Jenkins commented on patch set 2 10/30/13, 18:36

  7. Wouter Wolters commented on patch set 2 CR -1 10/30/13, 21:01

    We are changing TYPO3.Flow code here which was said before to do this as less as possible. My -1 is to make sure Thomas Maroschik can have a look at this. I will contact him;)
  8. Steffen Müller commented on patch set 2 10/30/13, 22:23

    Since we use an exception here, the Flow part of this changeset can easiliy be forward-ported to Flow. The exception message maybe needs some cosmetics then. The only blocker for me to do it is CLA. Can someone with signed CLA please try?
  9. Steffen Müller commented on patch set 2 10/30/13, 22:46

    Corresponding Flow issue at: http://forge.typo3.org/issues/53238
  10. Dmitry Dulepov commented on patch set 2 10/31/13, 12:55

    I would not put a -1 any more because I do not want to block the patch due to a message. But the message is still for devs, not for normal people. It is not user-friendly.
  11. Wouter Wolters commented on patch set 2 10/31/13, 13:09

    @steffen I can give that a try but not today. Hopefully tomorrow otherwise fridayevening.
  12. Steffen Müller commented on patch set 2 10/31/13, 15:18

    Dmitry, I'd appreciate if you contribute an example of a more user-friendly message for normal people. This could improve the patch and also teach us for the future.
  13. Dmitry Dulepov commented on patch set 2 11/01/13, 12:10

    An example of a better message is in my comment to the previous version of the patch. Basically, it should say something like "We could not update the list of installed packages because the file %s is not writable. Please, check file system permissions for this file and make sure that the web server can update it."
  14. Stefan Rotsch commented on patch set 2 11/01/13, 16:20

    Thanks for updating the exception message text!
  15. Steffen Müller uploaded patch set 3 11/01/13, 18:22

  16. Steffen Müller voted on patch set 3 V +1 CR +1 11/01/13, 18:23

  17. Steffen Müller commented on patch set 3 11/01/13, 18:23

    @Wouter: any news on the Flow backport?
  18. Wouter Wolters commented on patch set 3 11/01/13, 18:25

    Working on it;)
  19. Wouter Wolters commented on patch set 3 CR +1 11/01/13, 18:33

  20. Mr. Jenkins commented on patch set 3 11/01/13, 18:33

  21. Stefan Neufeind commented on patch set 3 V +2 CR +2 11/06/13, 23:12

    Worked fine for me. I actually ran into this problem in a production-installation (okay, broken permissions *sigh*) where installing an extension just silently failed until this patch.
  22. Stefan Neufeind merged patch set 4 11/06/13, 23:12