Review TYPO3_4-7 Merged

24978[BUGFIX] Cannot auto-load SC_* classes

Ernesto Baschny CR +2 V +2 Easy +0 −40 updated 10/28/13, 21:42

Commit message

These script files cannot be auto-loaded because they also include
runnable code.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Stefan Neufeind +1
  • Verified V +2
    • Ernesto Baschny +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 5

  1. Stefan Neufeind commented on patch set 1 CR +1 10/23/13, 17:28

    Went through the files removed from this list and verified they all contain code outside classes. They are to be executed directly, but not via autoloading.
  2. Stefan Neufeind commented on patch set 1 V +1 10/23/13, 17:34

    Didn't throughly verify "all" of my TYPO3 4.7 works, but at least it basically seems to work also with this patch etc.
  3. Ernesto Baschny commented on patch set 1 10/23/13, 19:23

    Another test idea is to run the phpunit without and with this patch applied and see if this solves the issue.
  4. Ernesto Baschny commented on patch set 1 V +2 CR +2 10/28/13, 21:42

    Let's get travis-47 green again before the T3CON :)
  5. Ernesto Baschny merged patch set 2 10/28/13, 21:42