25032[TASK] Fix static call to non-static method
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Steffen Müller +1
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Steffen Müller +1
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 10/28/13, 12:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11814/ : SUCCESS -
Wouter Wolters commented on patch set 1 10/30/13, 22:37
WorkspaceSelectorToolbarItem.php:78can be inside the checkAccess if-statement, right? -
Steffen Müller uploaded patch set 2 10/31/13, 09:27
-
Mr. Jenkins commented on patch set 2 10/31/13, 09:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11846/ : SUCCESS -
Wouter Wolters commented on patch set 2 CR -1 10/31/13, 09:47
WorkspaceSelectorToolbarItem.php:78if not loaded here. -
Steffen Müller uploaded patch set 3 10/31/13, 10:03
-
Mr. Jenkins commented on patch set 3 10/31/13, 10:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11847/ : SUCCESS -
Wouter Wolters commented on patch set 3 CR +1 10/31/13, 10:28
Thanks:-) -
Steffen Müller voted on patch set 3 V +1 CR +1 10/31/13, 10:54
-
Steffen Müller commented on patch set 3 10/31/13, 10:56
For testing you have to allow NOTICE to be logged using error_reporting(E_ALL); or configure the value in TYPO3_CONF_VARS. -
Georg Ringer voted on patch set 3 V +2 CR +2 10/31/13, 16:37
-
Georg Ringer merged patch set 4 10/31/13, 16:37