Review main Merged

25032[TASK] Fix static call to non-static method

Georg Ringer CR +2 V +2 Easy +21 −16 updated 10/31/13, 16:37

Commit message

The WS toolbar calls a method as static which is not

Review

  • Code review CR +2
    • Georg Ringer +2
    • Steffen Müller +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Steffen Müller +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 10/28/13, 12:39

  2. Wouter Wolters commented on patch set 1 10/30/13, 22:37

    WorkspaceSelectorToolbarItem.php:78

    can be inside the checkAccess if-statement, right?
  3. Steffen Müller uploaded patch set 2 10/31/13, 09:27

  4. Mr. Jenkins commented on patch set 2 10/31/13, 09:41

  5. Wouter Wolters commented on patch set 2 CR -1 10/31/13, 09:47

    WorkspaceSelectorToolbarItem.php:78

    if not loaded here.
  6. Steffen Müller uploaded patch set 3 10/31/13, 10:03

  7. Mr. Jenkins commented on patch set 3 10/31/13, 10:14

  8. Wouter Wolters commented on patch set 3 CR +1 10/31/13, 10:28

    Thanks:-)
  9. Steffen Müller voted on patch set 3 V +1 CR +1 10/31/13, 10:54

  10. Steffen Müller commented on patch set 3 10/31/13, 10:56

    For testing you have to allow NOTICE to be logged using error_reporting(E_ALL); or configure the value in TYPO3_CONF_VARS.
  11. Georg Ringer voted on patch set 3 V +2 CR +2 10/31/13, 16:37

  12. Georg Ringer merged patch set 4 10/31/13, 16:37