Review main Merged

25035[BUGFIX] filemetadata: differenciate between file types

Ernesto Baschny CR +2 V +2 Easy +1 −12 updated 11/09/13, 15:40

Commit message

filemetadata provides different set of meta data fields depending on
the file type.  This is now working as intended by referring to the
type field in the sys_file table.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 2

Review log 10

  1. Wouter Wolters voted on patch set 1 CR +1 10/28/13, 21:05

  2. Mr. Jenkins commented on patch set 1 10/28/13, 21:14

  3. Frans Saris voted on patch set 1 CR +1 10/28/13, 22:24

  4. Frans Saris commented on patch set 1 CR 0 10/29/13, 07:16

    I think we should also add the type and icons to the default file_metadata TCA. This was before also part of core. typo3/sysext/core/Configuration/TCA/sys_file_metadata.php
  5. Frans Saris commented on patch set 1 10/29/13, 07:51

    the icon part is currently not supported by IconUtility::mapRecordTypeToSpriteIconName() By changing this function a little I see forge issue for more info
  6. Steffen Ritter wrote 11/09/13, 08:28

    Topic updated from "filemetadata" to "fal".
  7. Steffen Ritter uploaded patch set 2 11/09/13, 15:26

  8. Steffen Ritter commented on patch set 2 V +2 CR +2 11/09/13, 15:33

    Reduced it to a one line patch - beeing a nobrainer
  9. Steffen Ritter merged patch set 3 11/09/13, 15:33

  10. Mr. Jenkins commented on patch set 2 11/09/13, 15:40