Review main Merged

25042[BUGFIX] Incorrect class names used in Install.php script

Claus Due CR +2 V +2 Easy +2 −2 updated 10/30/13, 23:32

Commit message

Fixes an incorrect use of lowercase extension-key component
in "install" extension's Install.php script.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 10/28/13, 23:31

  2. Wouter Wolters updated the commit message in patch set 1 10/29/13, 07:44

  3. Wouter Wolters commented on patch set 2 V +1 CR +1 10/29/13, 07:45

    Thanks Claus, this is only present in master branch. For example 6.1 doesn't have this class: https://git.typo3.org/Packages/TYPO3.CMS.git/tree/TYPO3_6-1:/typo3/sysext/install
  4. Mr. Jenkins commented on patch set 2 10/29/13, 07:55

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 10/30/13, 22:36

  6. Wouter Wolters merged patch set 3 10/30/13, 22:36

  7. Claus Due commented on patch set 3 10/30/13, 23:32

    Thanks Wouter - sorry for not amending this myself; time is a bit short. Had a suspicion it only applied to 6.2.