25050[BUFGIX] set password length to 8 in installtool
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Steffen Müller +1
-
Verified V +2
- Stefan Neufeind +2
- Steffen Müller +1
Issues 1
Files 1
Review log 7
-
Mr. Jenkins commented on patch set 1 10/29/13, 15:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11824/ : SUCCESS -
Stefan Neufeind commented on patch set 1 CR +1 10/30/13, 14:02
Install.js:315Should we raise the other values then? 10 and 12 chars or so? -
Steffen Müller commented on patch set 1 10/30/13, 16:19
Install.js:315ReplyThese kinds of strength algorithms are IMHO crap. They indicate a password like qqqqqQ1! more strong than correcthorsebatterystaplewithhughamountsofentropy see http://xkcd.com/936/ So I would either just fix the issue with the current patch or rework the algorithm -
Steffen Müller voted on patch set 1 V +1 CR +1 10/30/13, 16:19
-
Steffen Müller commented on patch set 1 10/30/13, 16:20
@Stefan I you'd also verify this one, it could be merged -
Stefan Neufeind voted on patch set 1 V +2 CR +2 10/30/13, 16:59
-
Stefan Neufeind merged patch set 2 10/30/13, 16:59