Review main Merged

25050[BUFGIX] set password length to 8 in installtool

Stefan Froemken CR +2 V +2 Easy +2 −2 updated 10/30/13, 16:59

Commit message

The installtool requires a password length of 8 letters,
but background of new password changes to yellow
after just 6 letters.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Steffen Müller +1
  • Verified V +2
    • Stefan Neufeind +2
    • Steffen Müller +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 10/29/13, 15:05

  2. Stefan Neufeind commented on patch set 1 CR +1 10/30/13, 14:02

    Install.js:315

    Should we raise the other values then? 10 and 12 chars or so?
  3. Steffen Müller commented on patch set 1 10/30/13, 16:19

    Install.js:315 Reply

    These kinds of strength algorithms are IMHO crap. They indicate a password like qqqqqQ1! more strong than correcthorsebatterystaplewithhughamountsofentropy see http://xkcd.com/936/ So I would either just fix the issue with the current patch or rework the algorithm
  4. Steffen Müller voted on patch set 1 V +1 CR +1 10/30/13, 16:19

  5. Steffen Müller commented on patch set 1 10/30/13, 16:20

    @Stefan I you'd also verify this one, it could be merged
  6. Stefan Neufeind voted on patch set 1 V +2 CR +2 10/30/13, 16:59

  7. Stefan Neufeind merged patch set 2 10/30/13, 16:59