2506[BUGFIX][INSTALL] Selecting existing database should check radio button
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Philipp Gampe +1
-
Verified V +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 10
-
Stefan Neufeind commented on patch set 1 06/25/11, 06:22
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 1 06/25/11, 06:22
Looks good to me, approved Couldn't apply it to 4_5 because of the changed submodules. -
Stefan Neufeind commented on patch set 2 06/25/11, 06:22
Verified; Looks good to me, but someone else must approve so here the votes again :-) -
Jigal van Hemert commented on patch set 2 V 0 06/25/11, 06:22
by team member; Looks good to me, approved Applies cleanly. Now works in 4_5 too :-) -
Philipp Gampe commented on patch set 2 06/25/11, 06:22
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 06/25/11, 06:22
I just rebased the changes to work around submodule issues. So the vote Stefan still applies (+1v +1cr) -
Philipp Gampe uploaded patch set 2 06/25/11, 06:22
-
Mr. Jenkins commented on patch set 1 06/25/11, 06:22
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/140/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/25/11, 06:22
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/171/ : SUCCESS -
Jigal van Hemert merged patch set 2 06/25/11, 06:22