Review TYPO3_4-5 Merged

2506[BUGFIX][INSTALL] Selecting existing database should check radio button

Steffen Gebert CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Due to a JavaScript error the corresponding radio button in Step 2 of
the 1-2-3 wizard is not automatically checked, when the dropdown menu
to select an existing database changes.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 10

  1. Stefan Neufeind commented on patch set 1 06/25/11, 06:22

    Verified; Looks good to me, but someone else must approve
  2. Jigal van Hemert commented on patch set 1 06/25/11, 06:22

    Looks good to me, approved Couldn't apply it to 4_5 because of the changed submodules.
  3. Stefan Neufeind commented on patch set 2 06/25/11, 06:22

    Verified; Looks good to me, but someone else must approve so here the votes again :-)
  4. Jigal van Hemert commented on patch set 2 V 0 06/25/11, 06:22

    by team member; Looks good to me, approved Applies cleanly. Now works in 4_5 too :-)
  5. Philipp Gampe commented on patch set 2 06/25/11, 06:22

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 2 06/25/11, 06:22

    I just rebased the changes to work around submodule issues. So the vote Stefan still applies (+1v +1cr)
  7. Philipp Gampe uploaded patch set 2 06/25/11, 06:22

  8. Mr. Jenkins commented on patch set 1 06/25/11, 06:22

  9. Mr. Jenkins commented on patch set 2 06/25/11, 06:22

  10. Jigal van Hemert merged patch set 2 06/25/11, 06:22